New delegate command to handle paste events #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
datho7561
added a commit
to datho7561/vscode-java
that referenced
this pull request
Nov 28, 2022
- Invoke jdt.ls's `java.edit.handlePasteEvent` command when vscode-java receives a paste event Requires eclipse-jdtls/eclipse.jdt.ls#2349 Closes redhat-developer#1249 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
1249-paste-into-string
branch
from
8310b59
to
f48765e
Compare
datho7561
added a commit
to datho7561/vscode-java
that referenced
this pull request
Nov 29, 2022
- Invoke jdt.ls's `java.edit.handlePasteEvent` command when vscode-java receives a paste event Requires eclipse-jdtls/eclipse.jdt.ls#2349 Closes redhat-developer#1249 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/vscode-java
that referenced
this pull request
Dec 1, 2022
- Invoke jdt.ls's `java.edit.handlePasteEvent` command when vscode-java receives a paste event Requires eclipse-jdtls/eclipse.jdt.ls#2349 Closes redhat-developer#1249 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/vscode-java
that referenced
this pull request
Dec 1, 2022
- Invoke jdt.ls's `java.edit.handlePasteEvent` command when vscode-java receives a paste event Requires eclipse-jdtls/eclipse.jdt.ls#2349 Closes redhat-developer#1249 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/vscode-java
that referenced
this pull request
Dec 12, 2022
- Invoke jdt.ls's `java.edit.handlePasteEvent` command when vscode-java receives a paste event Requires eclipse-jdtls/eclipse.jdt.ls#2349 Closes redhat-developer#1249 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
1249-paste-into-string
branch
from
f48765e
to
4479d74
Compare
datho7561
added a commit
to datho7561/vscode-java
that referenced
this pull request
Dec 12, 2022
- Invoke jdt.ls's `java.edit.handlePasteEvent` command when vscode-java receives a paste event Requires eclipse-jdtls/eclipse.jdt.ls#2349 Closes redhat-developer#1249 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
1249-paste-into-string
branch
from
4479d74
to
b62f28c
Compare
rgrunber
reviewed
Dec 22, 2022
Comment on lines
59
to
61
| if (object instanceof LinkedTreeMap) { | ||
| return gson.fromJson(gson.toJson(object), clazz); | ||
| } |
There was a problem hiding this comment.
LinkedTreeMap is internal to gson so we should avoid using it, mainly because it generates some warnings. However, you don't even need to use this if the client converts the object to a JSON string prior to sending in the delegate handler. In that case it'll be handled by the object instanceof String json from below.
I'll make the change.
- Add the command `java.edit.handlePasteEvent` to handle modifying paste events - Add logic to modify paste events when the user pastes into a `StringLiteral` Signed-off-by: David Thompson <davthomp@redhat.com>
rgrunber
force-pushed
the
1249-paste-into-string
branch
from
b62f28c
to
9b6d7f2
Compare
rgrunber
pushed a commit
to datho7561/vscode-java
that referenced
this pull request
Dec 22, 2022
- Invoke jdt.ls's `java.edit.handlePasteEvent` command when vscode-java receives a paste event Requires eclipse-jdtls/eclipse.jdt.ls#2349 Closes redhat-developer#1249 Signed-off-by: David Thompson <davthomp@redhat.com>
rgrunber
pushed a commit
to redhat-developer/vscode-java
that referenced
this pull request
Dec 22, 2022
- Invoke jdt.ls's `java.edit.handlePasteEvent` command when vscode-java receives a paste event Requires eclipse-jdtls/eclipse.jdt.ls#2349 Closes #1249 Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java.edit.handlePasteEventto handle modifying pasteevents
StringLiteralSigned-off-by: David Thompson davthomp@redhat.com