Use instanceof-pattern

[mickaelistria]

No description provided.

[fbricon]

Code doesn't compile:

16:18:35 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:3.0.0:compile (default-compile) on project org.eclipse.jdt.ls.core: Compilation failure: Compilation failure:
16:18:35 [ERROR] /home/jenkins/agent/workspace/jdt-ls-pr/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/corrections/proposals/GetterSetterCorrectionSubProcessor.java:[151]
16:18:35 [ERROR] if (!(coveringNode d SimpleName)) {
16:18:35 [ERROR] ^^^^^^^^^^^^
16:18:35 [ERROR] Syntax error on token "coveringNode", instanceof expected after this token
16:18:35 [ERROR] /home/jenkins/agent/workspace/jdt-ls-pr/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/corext/refactoring/reorg/ReorgPolicyFactory.java:[4604]
16:18:35 [ERROR] log.markAsProcessed(JavaElementResourceMapping.create(javaElement);
16:18:35 [ERROR] ^
16:18:35 [ERROR] Syntax error, insert ")" to complete Expression
16:18:35 [ERROR] /home/jenkins/agent/workspace/jdt-ls-pr/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/corext/refactoring/code/IntroduceParameterRefactoring.java:[287]
16:18:35 [ERROR] if (input instanceof ICompilationUnit cunit) {
16:18:35 [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
16:18:35 [ERROR] Expression type cannot be a subtype of the Pattern type
16:18:35 [ERROR] 3 problems (3 errors)

[mickaelistria]

The 2 first ones are typos.
The later one is strangely not failing with JDT...

[snjeza]

test this please

[snjeza]

test this please

[rgrunber]

I think this should be fine. I would just make sure to scan the entries for anything odd.

[rgrunber]

I think it looks pretty good. Haven't gone through all of it though :P

Just one small suggestion. I would avoid modifying anything under "org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/corext" for now. Those are classes that were copied directly from JDT and I'm guessing these refactorings haven't happened in JDT repo yet.

Whenever we move some class from jdt.ui into jdt.core.manipulation, it's good to compare, we compare it with ours before deleting our copy to see if we made any changes that are different. It's easier to do if the classes aren't refactored in only one repo.

[mickaelistria]

Just one small suggestion. I would avoid modifying anything under "org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/corext" for now

OK, I reverted those.

[mickaelistria]

Thanks for merging!