Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support matching case for code completion #2368

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

jdneo
Copy link
Contributor

@jdneo jdneo commented Dec 8, 2022

requires redhat-developer/vscode-java#2834

This PR adds a new preference 'java.completion.matchCase' to specify the case matching
behavior when doing code completion. Available options are:

  • FIRSTLETTER: Match case for the first letter only.
  • OFF: Do not match the case.

Some profiling results when doing completion in petclinic:

Case 1, completion after i:

  1 2 3 4 5 Avg.
firstLetter 368 58 60 52 107 129
off 421 115 88 85 90 159.8

Case 2, completion after e:

  1 2 3 4 5 Avg.
firstLetter 278 60 50 47 69 100.8
off 405 160 101 135 104 181

Case 3, completion after s:

  1 2 3 4 5 Avg.
firstLetter 368 240 84 126 61 175.8
off 530 221 166 152 151 244

Signed-off-by: sheche sheche@microsoft.com

Add a new preference 'java.completion.matchCase' to specify the case matching
behavior when doing code completion. Available options are:

- FIRSTLETTER: Match case for the first letter only.
- OFF: Do not match the case.

Signed-off-by: sheche <sheche@microsoft.com>
@snjeza snjeza self-requested a review December 9, 2022 04:11
@jdneo jdneo merged commit 45f31c1 into eclipse-jdtls:master Dec 15, 2022
@jdneo jdneo deleted the cs/match-case branch December 15, 2022 01:57
@rgrunber rgrunber added this to the Mid January 2023 milestone Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants