Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Linux config on FreeBSD systems #2408

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

schlomie
Copy link
Contributor

This addresses #2218

jdtls would fail to start, exiting early in the python launch script. FreeBSD was an unenumerated system, when determining which configuration to use. This commit instructs jdtls to treat FreeBSD in the same manner as it does Linux.

Note, this may not work in all use cases on FreeBSD, but I was able to use it without issue from Helix. It will probably work with neovim and others, but I have not personally tested other text editors.

At any rate, this change could offer a solution to other users of FreeBSD.

Signed-off-by: Loren Schlomer me@schlomie.com

Signed-off-by: Loren Schlomer <me@schlomie.com>
@eclipse-ls-bot
Copy link

Can one of the admins verify this patch?

@rgrunber rgrunber added this to the End February 2023 milestone Jan 19, 2023
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Even if it doesn't fully fix things, at least it's a step in the right direction. Also thanks for adjusting the exception.

@rgrunber rgrunber merged commit 9cbe473 into eclipse-jdtls:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants