Only do full build for configuration change when auto build enabled #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shi Chen <chenshi@microsoft.com>
CsCherrYY
force-pushed
the
cs-autobuild-nullanalysis
branch
from
f6680da
to
26aead0
Compare
| if (jvmChanged || nullAnalysisOptionsUpdated) { | ||
| boolean isAutobuildEnabled = preferenceManager.getPreferences().isAutobuildEnabled(); | ||
| boolean autoBuildChanged = ProjectsManager.setAutoBuilding(isAutobuildEnabled); | ||
| if (jvmChanged || nullAnalysisOptionsUpdated && isAutobuildEnabled) { | ||
| buildWorkspace(Either.forLeft(true)); | ||
| } else if (autoBuildChanged) { |
There was a problem hiding this comment.
it should be else if (autobuildchanged && isAutobuildEnabled) as well. We need to buildWorkspace only when autobuild is changed from false to true.
CsCherrYY
changed the title
Signed-off-by: Shi Chen <chenshi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When auto build is disabled, we should not do a full build for the change of the configurations since it might take a lot of time. This PR fixes that.
When auto build is enabled, we should do that to keep the state of the workspace update.
Signed-off-by: Shi Chen chenshi@microsoft.com