Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish diagnostics when auto-build is disabled #2447

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

CsCherrYY
Copy link
Contributor

Signed-off-by: Shi Chen chenshi@microsoft.com

This PR is a follow-up for #2437. When auto-build is disabled and some configurations changed, which need re-validate and publish diagnostics (e.g., null analysis configuration changed), we can do the publish job for open editors (via BaseDocumentLifeCycleHandler.publishDiagnostics) without triggering a rebuild.

null.mp4

Signed-off-by: Shi Chen <chenshi@microsoft.com>
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. Are there other instances aside from null analysis where we could re-publish diagnostics when the autobuild is off ?

@rgrunber rgrunber added this to the Mid February 2023 milestone Feb 9, 2023
@rgrunber rgrunber merged commit 7f18d6b into eclipse-jdtls:master Feb 9, 2023
@CsCherrYY CsCherrYY deleted the cs-null-without-autobuild branch February 10, 2023 01:39
@CsCherrYY
Copy link
Contributor Author

Are there other instances aside from null analysis where we could re-publish diagnostics when the autobuild is off ?

@testforstephen and me are investigating the features that could be affected if we disable the auto build. Aside from this, now we found

  • manually rename a symbol without any tips from references (when auto build is on, user can see errors from references)
  • hot code replace when debugging

The following PRs and issues will be created these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants