Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Convert String concatenation to Text Block' quick fix #2456

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Feb 10, 2023

Feb-10-2023 10-02-47

Signed-off-by: Fred Bricon fbricon@gmail.com

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon added this to the Mid February 2023 milestone Feb 10, 2023
@rgrunber
Copy link
Contributor

Nice. I think a bunch of the cleanups at https://github.com/eclipse/eclipse.jdt.ls/blob/7fa756765cd676a166570e243a3de44c3008892b/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/cleanup/CleanUpRegistry.java#L42-L52 could be candidates, provided their API supports being applied not just to a compilation unit, but a specific ASTNode.

Copy link
Contributor

@JessicaJHee JessicaJHee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works well!

@rgrunber rgrunber merged commit 8f89346 into eclipse-jdtls:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants