Update types filter according to import declarations #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update the types filter directly according to the import declarations.
This change has several benefits:
1. Quick fixes for unresolved types will also contain the types that are
already imported.
2. If the package/type is used in one compilation unit, it is a hint
that the package/type is used in other compilation units as well.
Signed-off-by: Sheng Chen <sheche@microsoft.com>
fbricon
reviewed
Feb 17, 2023
...dt.ls.tests/src/org/eclipse/jdt/ls/core/internal/correction/UnresolvedTypesQuickFixTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sheng Chen <sheche@microsoft.com>
|
test this please |
jdneo
changed the title
fbricon
reviewed
Feb 17, 2023
...clipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/CompletionHandlerTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sheng Chen <sheche@microsoft.com>
....ls.core/src/org/eclipse/jdt/ls/core/internal/contentassist/CompletionProposalRequestor.java
Show resolved
Hide resolved
Signed-off-by: Sheng Chen <sheche@microsoft.com>
snjeza
approved these changes
Feb 20, 2023
Signed-off-by: Sheng Chen <sheche@microsoft.com>
testforstephen
approved these changes
Feb 22, 2023
|
Profiled the impact of the added method on completion, the result shows that the impact is limited.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea comes from #2467 (comment).
This change has several benefits:
fix redhat-developer/vscode-java#2943