Move stream initialization to application #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickaelistria
force-pushed
the
streams
branch
from
6c0763a
to
d01e473
Compare
|
re-test this please. |
rgrunber
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
The streams only need to be redirected (so we can use them for client/server communication) prior to starting the application, and that's exactly where they're being moved.
If some plugin were to grab a reference to stdout and write on it, that might be an issue, but that's still the case without this patch, given how many plugins would need to be activated before jdt.ls.core. If this were really an issue, then we can always starting using our own stream/socket for communication.
I think we can merge after #2503 .
Stream initialization is needed prior to starting the application, so it can be moved out of plugin startup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the plugin can be installed in other environments without messing streams