Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to support decompiling class files #2515

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

JessicaJHee
Copy link
Contributor

rgrunber
rgrunber previously approved these changes Mar 17, 2023
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this. Should be fine after a rebase.

@rgrunber rgrunber dismissed their stale review March 19, 2023 15:59

One small change to make in order to better handle a corner case

@JessicaJHee JessicaJHee force-pushed the 2679-class-file branch 2 times, most recently from 897f401 to bdccd99 Compare March 20, 2023 20:34
Signed-off-by: Jessica He <jhe@redhat.com>
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling the other errors as well.

@rgrunber rgrunber merged commit 92d4c92 into eclipse-jdtls:master Mar 20, 2023
mfussenegger added a commit to mfussenegger/nvim-jdtls that referenced this pull request Mar 21, 2023
mfussenegger added a commit to mfussenegger/nvim-jdtls that referenced this pull request Mar 21, 2023
mfussenegger added a commit to mfussenegger/nvim-jdtls that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for .class files
2 participants