Reduce the target platform size by eliminating unnecessary bundles. #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only include org.eclipse.lsp4j and not bundles in the lsp4j feature - Only include required subset of the m2e.feature.group Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
datho7561
approved these changes
Mar 7, 2023
JessicaJHee
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real motivation for this change is I suspect some bundles being included through the m2e feature group, are severely slowing down the test runtime in Eclipse. I don't think it affects Maven. It's only Eclipse that will run a test by default, by including all bundles within the target platform.
The target platform is installed to
~/${your-jdt-ls-workspace}/.metadata/.plugins/org.eclipse.pde.core/.bundle_pool/plugins/. To test the difference I deleted the folder between changes.Before this change
783 bundles - 342MB
2.5min to run CleanUpsTest
With this change
685 bundles - 314MB
25s to run CleanUpsTest