Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support java.lang.Object for sysout postfix completion #2559

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

JessicaJHee
Copy link
Contributor

This change allows the sysout postfix completion to be used on Objects in addition to Strings.

This PR should close #1468 as it covers a similar use case.

Signed-off-by: Jessica He <jhe@redhat.com>
@fbricon
Copy link
Contributor

fbricon commented Mar 28, 2023

It's broken
Mar-28-2023 14-31-32

@fbricon
Copy link
Contributor

fbricon commented Mar 28, 2023

@rgrunber @snjeza same completion issue actually exists in latest vscode-java pre-release, on sysout postfix on Strings. Looks like the completion no longer waits for the document to be reconciled

edit: bug is not caused by this PR, See #2560.

@fbricon fbricon merged commit 3479842 into eclipse-jdtls:master Mar 28, 2023
4 checks passed
@fbricon
Copy link
Contributor

fbricon commented Mar 28, 2023

I checked reverting 00391c1 works, so this PR is good.
Thanks @JessicaJHee

@rgrunber rgrunber added this to the Early April 2023 milestone Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants