-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary files about "Change Signature refactoring" #2571
Conversation
...jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/cleanup/StringConcatToTextBlockCleanUp.java
Outdated
Show resolved
Hide resolved
I'm guessing the test failures are due to Java 20 support having been merged in the 4.28-I-builds ? So we probably need to do a release, then merge #2557 , and then we can merge this PR. |
test this please |
- Use the files directly from jdt.core.manipulation Signed-off-by: Shi Chen <chenshi@microsoft.com>
Hold on, there's a small problem here. Most of the classes (not all) have a 2nd copy already! The differences I think are mostly whitespace related but we should verify. So I guess we're saving ~12k lines 😮
Update: Let me just verify that the classes being removed are all functionally identical to their duplicate. Update 2: I've added a separate commit in the event that we discover some strange difference in behaviour, we can at least revert the part I introduced, since everything was fine before it. As far as I can tell, there isn't a difference though. |
- Also remove BodyUpdater & CollectingSearchRequestor Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
test this please. |
The PR is a follow-up of eclipse-jdt/eclipse.jdt.ui#428