Prevent sending shutdown job progress report #2622
Conversation
Signed-off-by: Jessica He <jhe@redhat.com>
|
retest this please. Nice. I think this is the right approach! The client can't wait for the notifications from shutdown, because the shutdown job could complete in some cases after the client has shut off. The nicer solution is to avoid notifying the client that shutdown has begun with |
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
|
retest this please. |
There was a problem hiding this comment.
Makes sense to merge. The shutdown job should not report anything back to the client because we cannot guarantee it can report it has completed.
In case you were wondering why we don't need to do the same at https://github.com/eclipse/eclipse.jdt.ls/blob/3fa7fbd9b904a61ff55720c2df7a270e13551c12/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/syntaxserver/SyntaxLanguageServer.java#L151 . The Syntax server doesn't register a progress report manager which sends notifications back to the client for jobs.
Relating to redhat-developer/vscode-java#2586, the status icon could continue spinning after restarting the language server since the shutdown job is never completed.
This change ensures that the progress report for the shutdown job is never sent to avoid this issue.