Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unnecessary completion item data field: decl_signature, signature, name #2638

Closed
jdneo opened this issue May 6, 2023 · 0 comments · Fixed by #2646
Closed

Remove the unnecessary completion item data field: decl_signature, signature, name #2638

jdneo opened this issue May 6, 2023 · 0 comments · Fixed by #2646

Comments

@jdneo
Copy link
Contributor

jdneo commented May 6, 2023

See: https://github.com/eclipse/eclipse.jdt.ls/blob/c98fd2cb5ff7f442a2a17c2dbc382f238c1a0a7c/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/CompletionResolveHandler.java#L91-L93

https://github.com/eclipse/eclipse.jdt.ls/blob/c98fd2cb5ff7f442a2a17c2dbc382f238c1a0a7c/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/contentassist/CompletionProposalDescriptionProvider.java#L702-L724

The content can be simply calculated from the proposal cached in the CompletionResponse. As long as we can recover the completion proposal, there is no need to set them into the data field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants