Fix pId mismatch bug in completion #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sheng Chen <sheche@microsoft.com>
jdneo
changed the title
testforstephen
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation might encounter situation that the
pIdmismatching between proposal and completion item.When the exception happens and caught. In that case, all the completion proposals will be stored into the response cache. While, only successfully resolved items will be stored.
Another part we can consider is that: is the try-catch block needed here. Looks like the invoked methods will not throw Exceptions in their signatures. Maybe @snjeza can provide more information. Related PR: https://github.com/eclipse/eclipse.jdt.ls/pull/1314/files