Smart semicolon autocorrect #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snjeza
requested review from
gorkem,
fbricon,
rgrunber,
jdneo and
testforstephen
fbricon
reviewed
Jun 19, 2023
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/SmartDetectionParams.java
Outdated
Show resolved
Hide resolved
snjeza
force-pushed
the
issue-703
branch
3 times, most recently
from
d740d72
to
6202173
Compare
|
So the Java partitioning gets us better detection of where we are in the code ? I'd be fine with this. These classes for the most part are easy to move, if not for the fact that some are API 😐 , and would also involve jface.text -> o.e.text . |
Right. It is also faster. |
snjeza
force-pushed
the
issue-703
branch
2 times, most recently
from
0fada23
to
850ac22
Compare
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
|
@rgrunber I have updated the PR. See redhat-developer/vscode-java#3159 (comment) |
rgrunber
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-java#703
Requires redhat-developer/vscode-java#3159