Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log the error when Gradle version and JDK version are mismatch #2749

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Log the error when Gradle version and JDK version are mismatch #2749

merged 1 commit into from
Jul 7, 2023

Conversation

jdneo
Copy link
Contributor

@jdneo jdneo commented Jul 7, 2023

No description provided.

testforstephen
testforstephen approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdneo
Log the error when Gradle version and JDK version are mismatch
e6af77b 
Signed-off-by: Sheng Chen <sheche@microsoft.com>
@jdneo
Copy link
Contributor Author

jdneo commented Jul 7, 2023

@testforstephen Just updated the PR, because the status is not error leveled, which will not trigger the telemetry sending event.

@testforstephen testforstephen added this to the End July 2023 milestone Jul 7, 2023
@testforstephen testforstephen merged commit 790eb6e into eclipse-jdtls:master Jul 7, 2023
5 of 6 checks passed
@jdneo jdneo deleted the cs/log branch July 9, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testforstephen testforstephen testforstephen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
End July 2023
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jdneo @testforstephen