Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not delete the project javanature when removing a nested .classpath resource file #2750

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

testforstephen
Copy link
Contributor

Running JUnit Plugin Tests of org.eclipse.jdt.ls.tests in VS Code causes Java extension to delete javanature from .project file of org.eclipse.jdt.ls.tests project. This is because the test framework removes temporary test projects (e.g. eclipse.jdt.ls/org.eclipse.jdt.ls.tests/target/workingProjects/maven/salut/.classpath) after testing, which triggers a .classpath delete event as part of didChangeWatchedFiles event. The language server then deletes javanature of the parent project when it detects a .classpath delete event. This is annoying when you dogfood eclipse.jdt.ls development in VS Code.

Here are the reproducing steps:

  1. Open the following eclipse-project in VS Code
eclipse-project
│   .classpath
│   .project
└───resources
        .classpath
  1. Delete .classpath file under resources folder
  2. You will see that javanature is removed from the .project file.

@testforstephen testforstephen added this to the End July 2023 milestone Jul 10, 2023
@testforstephen testforstephen merged commit 9752381 into eclipse-jdtls:master Jul 10, 2023
5 of 6 checks passed
@testforstephen testforstephen deleted the jinbo_fix branch July 10, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants