add logs for build workspace errors[default project] #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xuzho <xuzho@microsoft.com>
fbricon
reviewed
Nov 24, 2017
| StringBuilder builder = new StringBuilder(); | ||
| String message = marker.getAttribute(IMarker.MESSAGE, ""); | ||
| String code = String.valueOf(marker.getAttribute(IJavaModelMarker.ID, 0)); | ||
| builder.append("message:" + message); |
There was a problem hiding this comment.
you need to add some space, new line or a separator between the message attributes
fbricon
reviewed
Nov 24, 2017
|
|
||
| private static String convertMarker(IMarker marker) { | ||
| StringBuilder builder = new StringBuilder(); | ||
| String message = marker.getAttribute(IMarker.MESSAGE, ""); |
There was a problem hiding this comment.
marker.getAttribute(IMarker.MESSAGE, "<no message>");
fbricon
reviewed
Nov 24, 2017
| if (errors.isEmpty()) { | ||
| return BuildWorkspaceStatus.SUCCEED; | ||
| } else { | ||
| // for default project, problem markers aren't sent. Add logs here for trouble shooting. | ||
| logError("Met errors while building workspace." + String.join(";", errors)); |
There was a problem hiding this comment.
"Errors occured while building the workspace: "
Signed-off-by: xuzho <xuzho@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when building the workspace, diagnositics of errors from default project will be ignored. Add these errors to logs for trouble shooting,