Add quickfix for unreachable catch #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
reviewed
Dec 6, 2017
| } | ||
|
|
||
| Statement statement = ASTResolving.findParentStatement(node); | ||
| if (statement != catchClause.getParent() && statement != catchClause.getBody()) { |
There was a problem hiding this comment.
shouldn't you use equals(...) instead?
There was a problem hiding this comment.
@fbricon it is comparing 2 AST nodes. They should point to the same object instance in this case.
fbricon
reviewed
Dec 6, 2017
| return false; | ||
| } | ||
|
|
||
| if (resultingCollections == null) { |
There was a problem hiding this comment.
move that block at the beginning of the method, no need to compute anything if a simple check fails
fbricon
reviewed
Dec 6, 2017
| } | ||
|
|
||
| private static boolean isNotYetThrown(ITypeBinding binding, List<Type> thrownExceptions) { | ||
| for (int i = 0; i < thrownExceptions.size(); i++) { |
fbricon
reviewed
Dec 6, 2017
| @Test | ||
| public void testUnneededCatchBlock() throws Exception { | ||
| IPackageFragment pack1 = fSourceFolder.createPackageFragment("test1", false, null); | ||
| StringBuffer buf = new StringBuffer(); |
fbricon
reviewed
Dec 6, 2017
| public void testUnneededCatchBlockInInitializer() throws Exception { | ||
|
|
||
| IPackageFragment pack1 = fSourceFolder.createPackageFragment("test1", false, null); | ||
| StringBuffer buf = new StringBuffer(); |
fbricon
reviewed
Dec 6, 2017
| public void testUnneededCatchBlockSingle() throws Exception { | ||
|
|
||
| IPackageFragment pack1 = fSourceFolder.createPackageFragment("test1", false, null); | ||
| StringBuffer buf = new StringBuffer(); |
fbricon
reviewed
Dec 6, 2017
| public void testUnneededCatchBlockWithFinally() throws Exception { | ||
|
|
||
| IPackageFragment pack1 = fSourceFolder.createPackageFragment("test1", false, null); | ||
| StringBuffer buf = new StringBuffer(); |
|
test this please Hey wake up Jenkins! |
Signed-off-by: Yaohai Zheng <yaozheng@microsoft.com>
yaohaizh
force-pushed
the
yaohai_codeaction
branch
from
9985ba7
to
77f9707
Compare
|
Thanks for the new quick fixes @yaohaizh ! |
fbricon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yaohai Zheng yaozheng@microsoft.com
@fbricon @gorkem