Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not refresh folder structure during build #627

Merged
merged 1 commit into from
Apr 16, 2018
Merged

do not refresh folder structure during build #627

merged 1 commit into from
Apr 16, 2018

Conversation

SummerSun
Copy link

No description provided.

do not refresh folder structure during build
7430fec 
Signed-off-by: Summer Sun <victoriasqq@gmail.com>
@SummerSun SummerSun changed the title only refresh local folder when full build do not refresh folder structure during build Apr 16, 2018
@fbricon
Copy link
Contributor

fbricon commented Apr 16, 2018

What problem are you trying to fix?

@SummerSun
Copy link
Author

issue reported in debugger

Investigating the issue, we found that refreshLocal function call cost almost a minute for his complicated folder structure and that is not necessary for building workspace.

@fbricon fbricon merged commit bcd8f6a into eclipse-jdtls:master Apr 16, 2018
@fbricon fbricon added this to the Mid April 2018 milestone Apr 16, 2018
@SummerSun SummerSun deleted the qisun_fix branch April 20, 2018 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Mid April 2018
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SummerSun @fbricon