Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect jars in lib/ folder #927

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Feb 6, 2019

... in the root directory of standalone files / invisible projects

  • a file watcher on lib/** is added for invisible projects
  • source for foo.jar is automatically detected if there's a
    foo-sources.jar in the lib/ folder
  • multiple file events are handled so that classpath modifications are
    minimized

@snjeza
Copy link
Contributor

snjeza commented Feb 7, 2019

related issue #878

@snjeza
Copy link
Contributor

snjeza commented Feb 7, 2019

test this please

... in the root directory of  standalone files / invisible projects

- a file watcher on lib/** is added for invisible projects
- source for foo.jar is automatically detected if there's a
foo-sources.jar in the lib/ folder
- multiple file events are handled so that classpath modifications are
minimized

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon merged commit 905f39b into eclipse-jdtls:master Feb 7, 2019
@fbricon fbricon deleted the autodetect-jars branch February 7, 2019 03:28
@fbricon fbricon added this to the Mid February 2019 milestone Feb 7, 2019
leonardost added a commit to leonardost/kifu-recorder-tests that referenced this pull request May 30, 2019
I searched in a lot of places for how to import .jar files in VSCode,
and did not have much success. It seems VSCode prefers to use a project
build file (Maven, Gradle) to read dependencies. However, there's a new
feature where you put .jar files in a lib folder and it works.

redhat-developer/vscode-java#384
microsoft/vscode-java-debug#194
redhat-developer/vscode-java#501
eclipse-jdtls/eclipse.jdt.ls#927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants