Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mgmt API error page vulnerable to cross-site scripting attack #1067

Closed
Holger-Seemueller opened this issue Jan 11, 2021 · 4 comments
Closed
Labels
Milestone

Comments

@Holger-Seemueller
Copy link

Hi,

our security team reported an issue with our Hawkbit instance:

Request:
POST to /cgi-bin/<script>xss-test<script>.asp

Response:
{"timestamp":"2021-01-11T07:18:10.650+0000","status":404,"error":"Not Found","message":"Not Found","path":"/cgi-bin/<script>xss-test</script>.asp"}

I was able to reproduce this behavior on your sandbox instance. Btw. for GET requests the path is not returned.

Could you please provide a fix or a workaround for that behavior?

Kind regards,
Holger

@schabdo
Copy link
Member

schabdo commented Jan 12, 2021

Thanks for reporting the issue found by your security team. We'll see this fixed asap

@schabdo schabdo added the bug label Jan 12, 2021
@schabdo schabdo changed the title Cross-site scripting vulnurability Mgmt API error page vulnerable to cross-site scripting attack Jan 12, 2021
@schabdo
Copy link
Member

schabdo commented Jan 12, 2021

I would have expected that such special character within the URL are treated by Jetty. Tomcat behaves as expected:

IllegalArgumentException: Invalid character found in the request target [/cgi-bin/<script>xss-test</script>.asp]. 
The valid characters are defined in RFC 7230 and RFC 3986

@schabdo schabdo added this to the 0.3.0M7 milestone Jan 12, 2021
@Holger-Seemueller
Copy link
Author

Thanks for the quick response and reaction!!

@schabdo
Copy link
Member

schabdo commented Jan 15, 2021

Sure. I filed CVE-2020-27219 for the records

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants