Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1960] add status section for devices in API spec #2016

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

jbtrystram
Copy link
Contributor

Signed-off-by: Jean-Baptiste Trystram jbtrystram@redhat.com

@sophokles73 sophokles73 added Device Registry Management API issues related to the HTTP based API for managing the contents of the device registry and removed Device Registry labels Jun 4, 2020
@sophokles73 sophokles73 added this to In progress in 1.3.0 via automation Jun 4, 2020
@sophokles73 sophokles73 added this to the 1.3.0 milestone Jun 4, 2020
@jbtrystram jbtrystram requested a review from dejanb as a code owner June 5, 2020 07:54
@sophokles73
Copy link
Contributor

@jbtrystram any news on this one?

@jbtrystram
Copy link
Contributor Author

@sophokles73 Well I did the update after your last comment but never typed git push 😅
If this one seems OK to you we can let it sit there until all the other changes are accepted, then I'll bump the API version so we merge everything at once. WDYT ?

@sophokles73
Copy link
Contributor

@jbtrystram can you fix the failing unit tests?

@jbtrystram jbtrystram force-pushed the devicesStatusApiSpec branch 3 times, most recently from 6323d31 to 6ffe107 Compare July 1, 2020 08:42
Signed-off-by: Jean-Baptiste Trystram <jbtrystram@redhat.com>
Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ctron @dejanb @calohmn anything to add?

@ctron ctron merged commit 91225bc into eclipse-hono:master Jul 7, 2020
1.3.0 automation moved this from In progress to Done Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Management API issues related to the HTTP based API for managing the contents of the device registry
Projects
No open projects
1.3.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants