Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjustable capacity for the lockfree queue #216

Closed
MatthiasKillat opened this issue Aug 3, 2020 · 0 comments · Fixed by #364 or #393
Closed

Adjustable capacity for the lockfree queue #216

MatthiasKillat opened this issue Aug 3, 2020 · 0 comments · Fixed by #364 or #393
Assignees
@MatthiasKillat
Labels
enhancement New feature
Projects
v1.0 Sprints
Milestone
High prio

Comments

@MatthiasKillat
Copy link
Contributor

The lockfree queue is supposed to be used concurrently by multiple producers and consumers in an n to m communication scenario.

Since in some cases the size of the internal ringbuffer is not known at compile time but we cannot use dynamic memory, an option to adjust the capacity at runtime is needed. Due to the structure of the existing lockfree queue, this is even possible during concurrent operation (i.e. push and pops).
@mossmaurice mossmaurice added the enhancement New feature label Nov 2, 2020
@mossmaurice mossmaurice added this to the v1.0 milestone Nov 4, 2020
@mossmaurice mossmaurice added this to To do in v1.0 Nov 4, 2020
@MatthiasKillat MatthiasKillat moved this from To do to In progress in v1.0 Nov 12, 2020
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Nov 12, 2020
@MatthiasKillat
iox eclipse-iceoryx#216 simplification: remove unique index - correction
0f221a2 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Nov 12, 2020
@MatthiasKillat
iox eclipse-iceoryx#216 adapted tests to simplification
b0d6faa 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Nov 13, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 simplification-remove unique index
7e461d4 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Nov 13, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 adapted tests to simplification
cc1f2e9 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
@MatthiasKillat MatthiasKillat linked a pull request Nov 13, 2020 that will close this issue
Iox#216 lockfree queue preliminary simplification refactoring #364
Merged
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Nov 13, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 fixed failing test - different semantics of o…
c8eb60a 
…ptional

Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
v1.0 automation moved this from In progress to Done Nov 16, 2020
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Nov 17, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 extend cyclic index
dc88bf1 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Nov 17, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 extend index queue
67f8d41 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Nov 17, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 update header copyright
fff43eb 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
@elBoberido elBoberido added this to To do in Sprints via automation Nov 17, 2020
@elBoberido elBoberido moved this from To do to Done in Sprints Nov 17, 2020
This was referenced Nov 24, 2020
Merged
Closed
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Nov 25, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 correct copyright headers
0bcc867 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Nov 25, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 fix typename vs class cpp17 issue
9fcde58 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
@elBoberido elBoberido moved this from In progress to Review in Sprints Nov 25, 2020
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Nov 25, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 fix type conversion in test
1f9ea1c 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Nov 25, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 refactor test to avoid type conversion
9d70aa3 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Nov 25, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 change test queue data to be uint64_t
e4bae26 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Nov 25, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 fix narrowing conversion
d13d14e 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Nov 25, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 fix incorrect header
76f78db 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Dec 3, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 removed container version of setCapacity
66ec8c8 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Dec 3, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 refined interface and documentation
01468b8 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Dec 3, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 postponed load in popIfSizeIsAtLeast and fixe…
66229ec 
…d findings

Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Dec 3, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 made local variables const if possible
6f9227b 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Dec 3, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 made some methods of the index queue private
7d1c999 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Dec 3, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 reworked resizable queue tests
f284a75 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Dec 3, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 improved logic of popIfSizeIsAtLeast for the …
ecd5663 
…0 case

Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Dec 3, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 more tests for resizeable queue with removeHa…
9bacfff 
…ndler

Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Dec 3, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 reworked index queue tests
6fb6290 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Dec 4, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 simplify resizeable queue stresstests - part1
55d5e68 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Dec 4, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 simplify resizeable queue stresstests - part2
304036f 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Dec 4, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 fix counting problem in completeness stresstest
6e91969 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Dec 4, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 simplify producer logic in test
ab8523c 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Dec 8, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 fixed review findings in the tests
8479e93 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Dec 8, 2020
@MatthiasKillat
Merge branch 'master' into iox-eclipse-iceoryx#216-implement-lockfree…
2984b71 
…-queue-adjustable-capacity
MatthiasKillat added a commit to ApexAI/iceoryx that referenced this issue Dec 8, 2020
@MatthiasKillat
iox-eclipse-iceoryx#216 fix off by one error in count vector
0db0c4f 
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
v1.0 automation moved this from In progress to Done Dec 8, 2020
Sprints automation moved this from Review to Done Dec 8, 2020
MatthiasKillat added a commit that referenced this issue Dec 8, 2020
@MatthiasKillat
Merge pull request #393 from ApexAI/iox-#216-implement-lockfree-queue…
8d1bd34 
…-adjustable-capacity

Iox #216 implement lockfree queue adjustable capacity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatthiasKillat MatthiasKillat

Labels
enhancement New feature
Projects
No open projects
Sprints
Done
v1.0
  
Done
Milestone
High prio
4 participants
@mossmaurice @elfenpiff @elBoberido @MatthiasKillat