Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move HttpCompliance to HttpConfiguration #3011

Closed
joakime opened this issue Oct 22, 2018 · 1 comment
Closed

Move HttpCompliance to HttpConfiguration #3011

joakime opened this issue Oct 22, 2018 · 1 comment
Assignees
@joakime
Labels
Enhancement
Milestone
10.0.x

Comments

@joakime
Copy link
Contributor

joakime commented Oct 22, 2018

Currently, in Jetty 10.x, the HttpCompliance configuration isn't actually configurable in the HttpConfiguration class, but is instead passed into the HttpConnectionFactory.

Recommend moving it to the HttpConfiguration class to put all of the Compliance modes in a single place. (the HttpConnectionFactory can just interrogate the HttpConfiguration for it instead)

(Discovered during the analysis of #3009)
@joakime joakime added this to the 10.0.x milestone Oct 22, 2018
@joakime joakime self-assigned this Oct 22, 2018
joakime added a commit that referenced this issue Oct 22, 2018
@joakime
Issue #3011 - Moving HttpCompliance to HttpConfiguration
30853b9 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Oct 22, 2018
@joakime
Issue #3011 - Moving HttpCompliance to HttpConfiguration
4679565 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Oct 22, 2018
@joakime
Issue #3011 - Removing HttpConnectionFactory.getHttpCompliance()
fbd9fc1 
+ Can get HttpCompliance from HttpConfiguration now
+ Signature change to HttpConnection to avoid duplicate arguments
  on constructor.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Oct 22, 2018
@joakime
Merge pull request #3017 from eclipse/jetty-10.x-issue-3011-move-http…
405a6b6 
…compliance-to-config

Issue #3011 - Moving HttpCompliance to HttpConfiguration
sbordet pushed a commit that referenced this issue Oct 23, 2018
@joakime @sbordet
Issue #3011 - Moving HttpCompliance to HttpConfiguration
97b1932 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
sbordet pushed a commit that referenced this issue Oct 23, 2018
@joakime @sbordet
Issue #3011 - Removing HttpConnectionFactory.getHttpCompliance()
d55ff59 
+ Can get HttpCompliance from HttpConfiguration now
+ Signature change to HttpConnection to avoid duplicate arguments
  on constructor.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime
Copy link
Contributor Author

joakime commented Nov 6, 2018

Closing, merged in commit 405a6b6

@joakime joakime closed this as completed Nov 6, 2018
sbordet added a commit that referenced this issue Nov 29, 2018
@sbordet
Issue #3011 - Move HttpCompliance to HttpConfiguration.
99d1983 
Fixed jetty-https.xml.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Enhancement
Projects
None yet
Milestone
10.0.x
Development

No branches or pull requests
1 participant
@joakime