Issue #5816 : JMX-ify Scheduler implementations #5821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ravi Kumar <kumarravi1165@gmail.com>
sbordet
requested changes
Dec 17, 2020
| @@ -37,6 +39,7 @@ | |||
| * queue even if the task did not fire, which provides a huge benefit in the performance | |||
| * of garbage collection in young generation. | |||
| */ | |||
| @ManagedObject("A scheduler") | |||
There was a problem hiding this comment.
The description does not add any value, so just remove it.
| @@ -154,4 +157,22 @@ public boolean cancel() | |||
| return scheduledFuture.cancel(false); | |||
| } | |||
| } | |||
|
|
|||
| @ManagedAttribute("name of scheduler") | |||
There was a problem hiding this comment.
Use "The name of the scheduler".
| return name; | ||
| } | ||
|
|
||
| @ManagedAttribute("is scheduler daemon") |
There was a problem hiding this comment.
Use "Whether the scheduler uses daemon threads".
| return daemon; | ||
| } | ||
|
|
||
| @ManagedAttribute("number of scheduler threads") |
There was a problem hiding this comment.
Use "The number of scheduler threads".
Signed-off-by: Ravi Kumar <kumarravi1165@gmail.com>
sbordet
approved these changes
Dec 18, 2020
|
Thanks! |
This was referenced Mar 10, 2021
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ravi Kumar kumarravi1165@gmail.com