Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jakarta.servlet.jsp.jstl version 2 implementation from Eclipse Glassfish #5941

Closed
janbartel opened this issue Feb 3, 2021 · 1 comment
Closed
Assignees

Comments

@janbartel
Copy link
Contributor

@janbartel janbartel commented Feb 3, 2021

For jetty-11, we have been mashing up the 1.2 version of the org.apache.taglibs implementation to shade in the jakarta.servlet api instead of the javax.servlet api. This was just a temporary fix to allow us to keep developing jetty-11 with the jakarta.servlet namespace. Note also that while our org.mortbay.taglibs-standard.jar contained the shaded classes, the -source jar we have been publishing still contains the javax.servlet api references.

The Eclipse Glassfish project has made available a 2.0 version, using the proper jakarta.servlet api. It is released under Eclipse License 2.0.

We should change to use it.

@janbartel janbartel self-assigned this Feb 3, 2021
@janbartel janbartel added this to To do in Jetty 11.0.1 via automation Feb 3, 2021
janbartel added a commit that referenced this issue Feb 3, 2021
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Feb 3, 2021
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Feb 10, 2021
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Feb 10, 2021
* Issue #5941 Use Glassfish JSTL impl

Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel
Copy link
Contributor Author

@janbartel janbartel commented Feb 10, 2021

Closed via #5942

@janbartel janbartel closed this Feb 10, 2021
Jetty 11.0.1 automation moved this from To do to Done Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant