Fix outdated bundle vendor #2899
Conversation
Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
|
@quaff I don't understand the necessity for the changes here - looks like you've just changed the Implementation-Vendor entry in the manifest? Can you explain what the problem is you want to fix? I just ran jetty-9.4.12 release (from the distro) and I got the proper version as I expect:
|
|
@janbartel I'm guessing it has something to do with the bundle vendor in the jetty-all aggregate being "Eclipse Jetty Project" |
|
Yes, I'm using jetty-all. |
| @@ -307,7 +307,7 @@ | |||
| <Bundle-ManifestVersion>2</Bundle-ManifestVersion> | |||
| <Bundle-Name>${project.name}</Bundle-Name> | |||
| <Bundle-SymbolicName>${bundle-symbolic-name}.source</Bundle-SymbolicName> | |||
| <Bundle-Vendor>Eclipse.org - Jetty</Bundle-Vendor> | |||
| <Bundle-Vendor>Eclipse Jetty Project</Bundle-Vendor> | |||
There was a problem hiding this comment.
Yeah, it probably should be called "Eclipse Jetty Project".
WDYT @jmcc0nn3ll ?
There was a problem hiding this comment.
That is what it is in most of our jars, so let's be consistent
| @@ -307,7 +307,7 @@ | |||
| <Bundle-ManifestVersion>2</Bundle-ManifestVersion> | |||
| <Bundle-Name>${project.name}</Bundle-Name> | |||
| <Bundle-SymbolicName>${bundle-symbolic-name}.source</Bundle-SymbolicName> | |||
| <Bundle-Vendor>Eclipse.org - Jetty</Bundle-Vendor> | |||
| <Bundle-Vendor>Eclipse Jetty Project</Bundle-Vendor> | |||
There was a problem hiding this comment.
That is what it is in most of our jars, so let's be consistent
Jetty version will always be "9.4.z-SNAPSHOT" not exact "9.4.8.v20171121".