Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing @Deprecated methods / classes from jetty-9.4.x merge #4021

Merged
merged 2 commits into from Sep 24, 2019

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Aug 23, 2019

Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jaspi auth tests are now failing.... so either the tests need to be removed or something else needs to be modified.

Why does Jaspi have it's own BASIC auth module anyway?

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime
Copy link
Contributor Author

joakime commented Aug 27, 2019

@gregw I moved the BasicAuthModule to src/test/java as it's only used for testing purposes (as a demo of how to use the BaseAuthModule in src/main/java)

@joakime joakime added this to To Do in Jetty 10.0.0 via automation Aug 28, 2019
@joakime joakime requested a review from gregw September 17, 2019 15:38
@joakime joakime merged commit 6ebc784 into jetty-10.0.x Sep 24, 2019
@joakime joakime deleted the jetty-10.0.x-remove-deprecations branch September 24, 2019 18:37
@joakime joakime moved this from To Do to In Review in Jetty 10.0.0 Nov 20, 2019
@joakime joakime moved this from In Review to Done in Jetty 10.0.0 Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Jetty 10.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants