Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4857 - add setReuseAddress() to ClientConnector #4858

Merged
merged 2 commits into from May 8, 2020
Merged

Issue #4857 - add setReuseAddress() to ClientConnector #4858

merged 2 commits into from May 8, 2020

Conversation

lorban
Copy link
Contributor

@lorban lorban commented May 8, 2020

Closes #4857

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban marked this pull request as ready for review May 8, 2020 13:25
@joakime joakime added this to To Do in Jetty 10.0.0 via automation May 8, 2020
@joakime joakime moved this from To Do to In Review in Jetty 10.0.0 May 8, 2020
@sbordet sbordet self-requested a review May 8, 2020 15:16
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
{
connector.setReuseAddress(reuseAddress);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these, must only be in ClientConnector.

{
connector.setReuseAddress(reuseAddress);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

{
getHttpClient().setReuseAddress(reuseAddress);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these too.

@sbordet sbordet merged commit aa52d67 into jetty:jetty-10.0.x May 8, 2020
Jetty 10.0.0 automation moved this from In Review to Done May 8, 2020
@joakime joakime changed the title Jetty 10.0.x 4857 set reuse address Issue #4857 - add setReuseAddress() to ClientConnector May 8, 2020
@lorban lorban deleted the jetty-10.0.x-4857-setReuseAddress branch May 8, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Jetty 10.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

Add setReuseAddress() to Jetty 10's ClientConnector
2 participants