simplify the usage of WebSocketUpgradeFilter in jetty 10 #5413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
commented
Oct 9, 2020
...til-server/src/main/java/org/eclipse/jetty/websocket/util/server/WebSocketUpgradeFilter.java
Outdated
Show resolved
Hide resolved
…WebSocketUpgradeFilter
gregw
requested changes
Oct 12, 2020
There was a problem hiding this comment.
I'm not really convinced this is workable as I'm not sure you can always convert a className into a class at the point you need to.
They might extend the jetty servlet in their application, so the classname may be for something in the webapp, which might not be loadable until started.
Looking at the init param feels safer to me.
Let's discuss.
jetty-servlet/src/main/java/org/eclipse/jetty/servlet/FilterHolder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
If a user wants to use the WebSocketUpgradeFilter with a different WebSocketMapping, they can add the ServerContainer manually and put their own WebSocketMapping in. Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
approved these changes
Nov 2, 2020
…WebSocketUpgradeFilter Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
|
@gregw yes but also a change in behaviour, the |
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now anyWebSocketUpgradeFilterwill use the defaultWebSocketMappingattribute by default. And we will not add aWebSocketUpgradeFilterautomatically in theJettyWebSocketServletContainerInitializerif we detect there is already one added.WebSocketUpgradeFiltermapping init param name and default value.WebSocketUpgradeFilterit will throw in itsinit()method.