YAML Multiline block indicator issue

[jfbourner]

Describe the bug

When adding ISTIO configuration, via the annotations config, it is setting a Block Chomping Indicator to clip the new line, where it needs to retain the new line.
Yaml Multiline
ISTIO Config

POM Plugin config

<resources>
	<annotations>
		<all>
			<property>
				<name>proxy.istio.io/config</name>
				<value>proxyMetadata:
    ISTIO_META_DNS_CAPTURE: "false"
holdApplicationUntilProxyStarts: true</value>
			</property>
		</all>
	</annotations>
</resources>

Deployment.yml Output

metadata:
    annotations:
      proxy.istio.io/config: |-
        proxyMetadata:
            ISTIO_META_DNS_CAPTURE: "false"
        holdApplicationUntilProxyStarts: true

As you can see above the deployment yaml has "|-" which causes the annotation to not work with ISTIO

Eclipse JKube version

1.9.1

Component

Kubernetes Maven Plugin

Apache Maven version

3.8.3

Gradle version

No response

Steps to reproduce

1. Configure the maven plugin - annotation - with multiline text.
2. Build it using mvn k8s:resource
3. Check target output

Expected behavior

Expected output

metadata:
    annotations:
      proxy.istio.io/config:  |
        proxyMetadata:
            ISTIO_META_DNS_CAPTURE: "false"
        holdApplicationUntilProxyStarts: true

Runtime

Kubernetes (vanilla)

Kubernetes API Server version

other (please specify in additional context)

Environment

Windows, Linux

Eclipse JKube Logs

No response

Sample Reproducer Project

Sits on commercial infra

Additional context

No response

[rohanKanojia]

@jfbourner : Thanks for reporting, I can reproduce the issue. I think this behavior is coming from our Jackson ObjectMapper in ResourceUtil which is not doing serialization as expected.

https://github.com/eclipse/jkube/blob/63ab8d3a3239f20da0f1ccc747ad219153d7af32/jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/ResourceUtil.java#L55-L56

In the meantime, Could you please check if using mvn k8s:resource -Djkube.resourceType=json works for your project as a workaround?

[rohanKanojia]

Nope, my previous assumption was wrong.

Jackson ObjectMapper is doing what it is supposed to do. Somehow trailing newline doesn't seem to be added to annotation value via this config:

                            <property>
                                    <name>proxy.istio.io/config</name>
                                    <value>proxyMetadata:
    ISTIO_META_DNS_CAPTURE: "false"
holdApplicationUntilProxyStarts: true</value>
                            </property>

this generates annotation with value: proxyMetadata:\n ISTIO_META_DNS_CAPTURE: "false"\nholdApplicationUntilProxyStarts: true (notice there is no newline at the end) . This results in Jackson adding |- which means strip ending newline.

I tried adding 
 to enforce newline at the end but it didn't work. This looks like an XML specific problem, in gradle I'm easily able to specify newline at the end. If I make changes in code to enforce trailing newline for multiline strings it correctly adds |