You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On a fresh build project, k8s:resource does not perform any resource validation:
$ mvn clean install k8s:resource
However, if you've already run k8s:resource before, you'd see validation on the second run. This behavior is due to validation method invoked before resource files are actually written:
…sources are generated by `k8s:resource` (eclipse-jkube#2008)
Resource validation should be done after resources are written.
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…sources are generated by `k8s:resource` (eclipse-jkube#2008)
Resource validation should be done after resources are written.
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…sources are generated by `k8s:resource` (eclipse-jkube#2008)
Resource validation should be done after resources are written.
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…sources are generated by `k8s:resource` (#2008)
Resource validation should be done after resources are written.
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Describe the bug
I observed this while working on #1934
On a fresh build project,
k8s:resource
does not perform any resource validation:However, if you've already run
k8s:resource
before, you'd see validation on the second run. This behavior is due to validation method invoked before resource files are actually written:https://github.com/eclipse/jkube/blob/174d1897655b8af31637d79728169768d2cf8004/kubernetes-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/ResourceMojo.java#L216-L217
Gradle Plugins don't seem to affected by this issue. They're correctly invoking validation after resource generation:
https://github.com/eclipse/jkube/blob/174d1897655b8af31637d79728169768d2cf8004/gradle-plugin/kubernetes/src/main/java/org/eclipse/jkube/gradle/plugin/task/KubernetesResourceTask.java#L91-L92
Eclipse JKube version
1.10.0
Component
Kubernetes Maven Plugin
Apache Maven version
3.8.5
Gradle version
None
Steps to reproduce
Run mvn clean install k8s:resource , no validation would be performed
Expected behavior
Validation should be performed after resource generation. Lines 216 and 127 should be swapped in ResourceMojo.java
Runtime
Kubernetes (vanilla)
Kubernetes API Server version
1.25.3
Environment
Linux
Eclipse JKube Logs
No response
Sample Reproducer Project
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: