Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace KubernetesHelper.printLogsAsync with OutputStream to KitLogger pipe #2194

Open
manusa opened this issue Jun 6, 2023 · 0 comments
Open
Assignees

Comments

@manusa
Copy link
Member

manusa commented Jun 6, 2023

Description

We currently have a KubernetesHelper.printLogsAsync:

https://github.com/eclipse/jkube/blob/16020273d0dd0065249b0079b68b16aba53134e9/jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/KubernetesHelper.java#L384-L410

That uses additional threads that aren't even managed by a thread scheduler to take care of printing a Container log asynchronously. This can easily be replaced by an OutputStream that can be passed to the client's watchLog method. The main purpose of this OutputStream would be to pipe the logged statements into the KitLogger.

@manusa manusa self-assigned this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant