Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceMojo : remove redundant method already defined in superclass #2872

Closed
2 tasks
rohanKanojia opened this issue Apr 3, 2024 · 2 comments · Fixed by #2883
Closed
2 tasks

ResourceMojo : remove redundant method already defined in superclass #2872

rohanKanojia opened this issue Apr 3, 2024 · 2 comments · Fixed by #2883
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@rohanKanojia
Copy link
Member

Component

Kubernetes Maven Plugin

Task description

Description

ResourceMojo seems to be overriding this method from it's parent class:
https://github.com/eclipse/jkube/blob/335aa3bcd76523c4f9ee89dab46225278b3ce20d/kubernetes-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/ResourceMojo.java#L182-L185

However, if you see the original method in super class, it's exactly the same:
https://github.com/eclipse/jkube/blob/335aa3bcd76523c4f9ee89dab46225278b3ce20d/kubernetes-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/AbstractJKubeMojo.java#L188-L190

There is no need to add @Override method if overridden implementation isn't doing anything different.

Expected Behavior

Remove redundant method from ResourceMojo that's already defined in AbstractJKubeMojo

Acceptance Criteria

  • getRuntimeMode() is removed from ResourceMojo
  • Project compiles cleanly after running mvn clean install
@rohanKanojia rohanKanojia added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 3, 2024
@professorabhay
Copy link
Contributor

hai, I would like to work on this. May I?

@Teja-11
Copy link
Contributor

Teja-11 commented Apr 8, 2024

Can i work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants