Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AssemblyConfigurationTest : Replace AssertJ's deprecated asList() DSL method with asInstanceOf(InstanceOfAssertFactories.list(type.class)) #3134

Closed
1 task done
rohanKanojia opened this issue Jun 5, 2024 · 1 comment · Fixed by #3143
Closed
1 task done

AssemblyConfigurationTest : Replace AssertJ's deprecated asList() DSL method with asInstanceOf(InstanceOfAssertFactories.list(type.class)) #3134

rohanKanojia opened this issue Jun 5, 2024 · 1 comment · Fixed by #3143
Assignees
@arman-yekkehkhani
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone
1.17.0

Comments

@rohanKanojia
Copy link
Member

rohanKanojia commented Jun 5, 2024 •
edited by manusa
Loading

Component

JKube Kit

Task description

Description

In the latest versions of Assertj asList() DSL method has been marked as deprecated:

jkube/jkube-kit/common/src/test/java/org/eclipse/jkube/kit/common/AssemblyConfigurationTest.java

Line 129 in 740279f

.extracting(Assembly::getFiles).asList().hasSize(1).first()

users are advised to use asInstanceOf(InstanceOfAssertFactories.list(type.class)) instead, we need to update asList() calls with this.

Expected Behavior

AssertJ's asList() is replaced with asInstanceOf(InstanceOfAssertFactories.list(type.class))

Acceptance Criteria

  • asList() DSL method call is replaced with asInstanceOf(InstanceOfAssertFactories.list(type.class)) in all places
@rohanKanojia rohanKanojia added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 5, 2024
@arman-yekkehkhani
Copy link
Contributor

@rohanKanojia Hi, Can I work on this one?

arman-yekkehkhani added a commit to arman-yekkehkhani/jkube that referenced this issue Jun 6, 2024
@arman-yekkehkhani
chore(deprecated assertions): replace deprecated assertions, issue ec…
d57f390 
…lipse-jkube#3134

Signed-off-by: arman-yekkehkhani <arman.yekkehkhani@gmail.com>
@arman-yekkehkhani arman-yekkehkhani mentioned this issue Jun 6, 2024
Merged
17 tasks
@manusa manusa added this to the 1.17.0 milestone Jun 7, 2024 — with automated-tasks
manusa pushed a commit that referenced this issue Jun 7, 2024
@arman-yekkehkhani
fix: replace AssertJ's deprecated asList() DSL method in AssemblyConf…
b0d8dd6 
…igurationTest #3134

Signed-off-by: arman-yekkehkhani <arman.yekkehkhani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arman-yekkehkhani arman-yekkehkhani

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
1.17.0
3 participants
@manusa @rohanKanojia @arman-yekkehkhani