Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SnakeYaml uses SafeConstructor or delegates to Fabric8 Kubernetes Client #1220

Merged
merged 1 commit into from Jan 24, 2022

Conversation

manusa
Copy link
Member

@manusa manusa commented Jan 19, 2022

Description

Fix #1213

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

…s Client

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa added this to the 1.6.0 milestone Jan 19, 2022
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #1220 (77d4245) into master (d8825b7) will increase coverage by 0.14%.
The diff coverage is 70.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1220      +/-   ##
============================================
+ Coverage     49.57%   49.72%   +0.14%     
- Complexity     3656     3663       +7     
============================================
  Files           455      456       +1     
  Lines         20625    20588      -37     
  Branches       2814     2803      -11     
============================================
+ Hits          10225    10237      +12     
+ Misses         9315     9283      -32     
+ Partials       1085     1068      -17     
Impacted Files Coverage Δ
...pse/jkube/kit/build/api/helper/DockerFileUtil.java 68.25% <ø> (+4.07%) ⬆️
...ig/handler/compose/DockerComposeConfigHandler.java 0.00% <0.00%> (ø)
...kit/build/api/helper/KubernetesConfigAuthUtil.java 68.88% <68.88%> (ø)
...api/auth/handler/OpenShiftRegistryAuthHandler.java 88.46% <100.00%> (+29.04%) ⬆️
...t/build/service/docker/auth/AuthConfigFactory.java 61.59% <100.00%> (+3.77%) ⬆️
...g/eclipse/jkube/kit/build/api/auth/AuthConfig.java 56.36% <0.00%> (+3.63%) ⬆️
...n/java/org/eclipse/jkube/kit/common/KitLogger.java 17.24% <0.00%> (+17.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8825b7...77d4245. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@manusa manusa merged commit 17ada41 into eclipse-jkube:master Jan 24, 2022
@manusa manusa deleted the fix/snakeyaml branch January 24, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use SafeContructor instead fo Yaml Empty contructor
3 participants