New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor (org.eclipse.jkube.kubernetes.gradle.plugin): Migrate tests from JUnit4 to JUnit5 (#1581) #1851
Conversation
Eclipse JKube CI ReportStarted new GH workflow run for #1851 (2022-11-03T09:49:22Z) ⚙️ JKube E2E Tests (3384431130)
|
Codecov Report
@@ Coverage Diff @@
## master #1851 +/- ##
=============================================
- Coverage 69.93% 21.30% -48.64%
+ Complexity 345 110 -235
=============================================
Files 43 43
Lines 1314 1314
Branches 88 88
=============================================
- Hits 919 280 -639
- Misses 351 1024 +673
+ Partials 44 10 -34
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8e4f024
to
3063814
Compare
.../kubernetes/src/test/java/org/eclipse/jkube/gradle/plugin/task/TaskEnvironmentExtension.java
Outdated
Show resolved
Hide resolved
3063814
to
fc17494
Compare
...ubernetes/src/test/java/org/eclipse/jkube/gradle/plugin/KubernetesExtensionPropertyTest.java
Show resolved
Hide resolved
...bernetes/src/test/java/org/eclipse/jkube/gradle/plugin/KubernetesPluginRegisterTaskTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the minor change request, and the question about the number of parameters, everything else LGTM.
fc17494
to
5dd3896
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
@manusa I want to know why the codecov bot reports merging this PR will decrease coverage by 3.08%. I also checked the impacted files but didn't understand what was happening there. |
Need to look into this. |
Hi @anurag-rajawat |
…from JUnit4 to JUnit5 (eclipse-jkube#1581) Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
5dd3896
to
08d85f0
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Fixes #1581
Type of change
test, version modification, documentation, etc.)
Checklist