issue-1832-LogMatchCallback has been fixed #2013
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit9625
requested review from
manusa,
rohanKanojia and
sunix
as code owners
Eclipse JKube CI ReportStarted new GH workflow run for #2013 (2023-01-25T12:30:35Z) ⚙️ JKube E2E Tests (4005757594)
|
|
Welcome, Thanks a lot for contributing to Eclipse JKube 👍, In order to contribute to Eclipse, you would need to create an Eclipse Account and Sign Eclipse Contributor Agreement. Once you've created an eclipse account you would need to update your commit message with a |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #2013 +/- ##
=========================================
Coverage 54.11% 54.11%
Complexity 4050 4050
=========================================
Files 480 480
Lines 21061 21061
Branches 2812 2812
=========================================
Hits 11397 11397
Misses 8499 8499
Partials 1165 1165
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rohanKanojia
approved these changes
Jan 25, 2023
|
Sorry, I am closing this PR because I created a new one about the same issue with better commit and comments. |
17 tasks
|
HI @rohit9625, why did you reopen this PR as you had already opened #2019 ? |
|
Sorry @anurag-rajawat , I opened this PR by mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1832
Hi there,
I have corrected a missing statement in line 27.
Before correcting it was private StringBuilder logBuffer;
and after correcting it became private final StringBuilder logBuffer