Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Feat/androidnfc plugin update #265

Merged
merged 27 commits into from Mar 30, 2020
Merged

Feat/androidnfc plugin update #265

merged 27 commits into from Mar 30, 2020

Conversation

ocfmem
Copy link
Contributor

@ocfmem ocfmem commented Feb 18, 2020

Updating Android NFC plugin

@eclipse-keyple-bot
Copy link

Can one of the admins verify this patch?

@ocfmem
Feat: Added Gradlew Wrapper for example App
8c837a9 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Refact: Gradle files.
6381772 
Feat: Version numbers updated

Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Refact: Java to Kotlin
bae3007 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Refact: Updating Android NFC Exampele app
69b2710 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Refact: Exemple App
c6ad8f9 
Feat: Added more generic use case

Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Fix: Fixed and improved Unit Tests
046e509 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Fix: Ignoring apply plugin: 'org.eclipse.keyple' for now in android k…
88ce715 
…eyple-plugins

Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem ocfmem force-pushed the feat/androidnfc_plugin_update branch from fcae6a3 to 88ce715 Compare March 2, 2020 14:30
@pterr pterr marked this pull request as ready for review March 3, 2020 06:08
ocfmem added 11 commits March 3, 2020 12:15
@ocfmem
Feat: Improve SE REmoved from field for Android >= 7
2e281fb 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Feat: Added Binding for slf4j with Timber
51e6d5a 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Refact: Removed fragment xml from omapi example app
603cd40 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Feat: Improvement of UI of example app
41cad63 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Fix: Code format
e653246 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Fix: Conflict between IDE Optimize imports ans Spotless
4d192b4 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Fix: logging issue with SeSelector.AidSelector usint AidToSelect = null
29402d5 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Fix: logging issue with SeSelector.AidSelector usint AidToSelect = null
b29e8f3 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Fix: Spotless Java
376bc77 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Fix: KEYP-26 crash on NFC Example App
12ab504 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Fix: KEYP-35 Improving SE presence check in example app.
4eba98e 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
pterr
pterr reviewed Mar 6, 2020
View reviewed changes
Copy link
Contributor

@pterr pterr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In keyple-java/NOTICE.md, the third-party dependency with "SLF4J for Timber" must be declared.

The file renaming AndroidNfcPluginFactory.java to android/nfc/AndroidNfcPluginFactory.kt has been identified by Git.
But it isn't the case for the other files of the plugins: so Git reports more line changes than necessary.

@ocfmem
Copy link
Contributor Author

ocfmem commented Mar 6, 2020

In keyple-java/NOTICE.md, the third-party dependency with "SLF4J for Timber" must be declared.

The file renaming AndroidNfcPluginFactory.java to android/nfc/AndroidNfcPluginFactory.kt has been identified by Git.
But it isn't the case for the other files of the plugins: so Git reports more line changes than necessary.
My PR already contains update of NOTICE.md for SLF4J for Timber.
I don't know why git identify some renaming and not others. By the way, as all is converted to Kotlin it seems normal to me that all the lines are new to git.

@ocfmem
Copy link
Contributor Author

ocfmem commented Mar 6, 2020

The file renaming AndroidNfcPluginFactory.java to android/nfc/AndroidNfcPluginFactory.kt has been identified by Git.
But it isn't the case for the other files of the plugins: so Git reports more line changes than necessary.

Looks like git can keep track of renaming if there is a few changes in the file. We can see it kept only small classes.

@ocfmem
Feat: Improved Javadoc
5e3ff1e 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Fix: Spotless issue
29ae4bc 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Refact: Renaming main activity to calypso activity
e318b88 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Feat: Added Core Examples
9e54398 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Feat: Test coverage improvement
43dca9e 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Feat: Test coverage improvement
70df0ff 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
ocfmem and others added 2 commits March 19, 2020 17:44
@ocfmem
Fix: Comments issues
6aadb93 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@eclipsewebmaster @ocfmem
Fix: Updating gradlew wrapper version for example app
375594d 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
pterr
pterr reviewed Mar 23, 2020
View reviewed changes
Copy link
Contributor

@pterr pterr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update /keyple-java/ReleaseNotes.md#keyple-android-plugin-android-nfc-09a ?

@ocfmem
Fix: Completed ReleaseNotes.md
c786cf5 
Signed-off-by: Meddy Menzikoff <m.menzikoff@oneclickflare.fr>
@ocfmem
Copy link
Contributor Author

ocfmem commented Mar 24, 2020

Could you update /keyple-java/ReleaseNotes.md#keyple-android-plugin-android-nfc-09a ?

Done.

@odelcroi odelcroi merged commit 317ea16 into eclipse-keyple:develop Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pterr pterr pterr left review comments

@odelcroi odelcroi odelcroi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ocfmem @eclipse-keyple-bot @odelcroi @pterr @eclipsewebmaster