Update contribution guide #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace information CONTRIBUTING.md because it is redundantly stored in each project repository. Instead, CONTRIBUTING.md now links to the project website that centralizes the information. * Links to kuksa-dev mailing list and Zoom meeting added. * References to Bugzilla have been removed because GitHub issues are used instead. * Clean code is mentioned to encourage a good code style and be able to refer to it when reviewing pull requests. * The documentation section has been updated to what has been agreed on lately. * Practical hints for commit style have been added. Signed-off-by: Sebastian Lohmeier <Sebastian.Lohmeier@bosch-si.com>
rohoet
reviewed
Jul 29, 2019
|
Nice. I guess to enfor.. encourage this, reviewers should also check and suggest changes if some PRs are not conforming. And I know, I will soon regret suggesting this... And I do not quite agree to the artificial squashing of things. . It creates work, and helps nobody. A commit can't be small enough. Squashing makes regression testing quite hard, because yeah maybe there was one breaking change in one line, but now it is lumped together with 1000 other commits. For indicating larger milestones/chunks of work there are tags in git. |
rohoet
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in each project repository. Instead, CONTRIBUTING.md now links to the
project website that centralizes the information.
used instead.
refer to it when reviewing pull requests.
lately.
Signed-off-by: Sebastian Lohmeier Sebastian.Lohmeier@bosch-si.com