Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing tags should be included in the code folding range #1178

Closed
ris58h opened this issue Feb 18, 2022 · 2 comments · Fixed by #1179
Closed

Closing tags should be included in the code folding range #1178

ris58h opened this issue Feb 18, 2022 · 2 comments · Fixed by #1179
Labels
enhancement New feature or request folding
Milestone

Comments

@ris58h
Copy link

ris58h commented Feb 18, 2022

For now folding regions don't contain closing tags. By folding them too we could save screen space and increase readability of big XML files such as pom.xml.

VSCode examples:
Actual behavior
Screenshot 2022-02-17 at 01 26 01

Desired behavior
Screenshot 2022-02-17 at 01 27 14

I've already create the same issue in vscode-xml but it seems that the right place for the issue is here.

@angelozerr
Copy link
Contributor

angelozerr commented Feb 21, 2022

@AlexXuChen
Copy link
Contributor

@AlexXuChen do you want to work on this issue?

Sure thing

@angelozerr angelozerr added this to the 0.19.2 milestone Feb 25, 2022
@angelozerr angelozerr added the enhancement New feature or request label Mar 28, 2022
@angelozerr angelozerr changed the title Fold closing tags too Closing tags should be included in the code folding range. Mar 29, 2022
@angelozerr angelozerr changed the title Closing tags should be included in the code folding range. Closing tags should be included in the code folding range Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request folding
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants