Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support xml.format.emptyElements setting with experimental formatter #1238

Closed
angelozerr opened this issue Jul 1, 2022 · 4 comments · Fixed by #1297
Closed

Support xml.format.emptyElements setting with experimental formatter #1238

angelozerr opened this issue Jul 1, 2022 · 4 comments · Fixed by #1297
Assignees
@JessicaJHee
Labels
enhancement New feature or request formatting This issue or enhancement is related to formatting support
Milestone
0.22.0

Comments

@angelozerr
Copy link
Contributor

See https://github.com/redhat-developer/vscode-xml/blob/master/docs/Formatting.md#xmlformatemptyelements
@angelozerr angelozerr added the formatting This issue or enhancement is related to formatting support label Jul 1, 2022
@angelozerr angelozerr changed the title Support xml.format.emptyElements setting with experimental formatter. Support xml.format.emptyElements setting with experimental formatter Jul 1, 2022
@JessicaJHee
Copy link
Contributor

I believe this setting is already supported by

lemminx/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/format/DOMElementFormatter.java

Line 93 in 4cd0a54

case expand: {

It also passes the first 3 tests in

lemminx/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/services/format/experimental/XMLFormatterEmptyElementsTest.java

Line 34 in 4cd0a54

public void expandEmptyElements() throws BadLocationException {

Is the idea here to try to further support this with some invalid xml?

@angelozerr
Copy link
Contributor Author

I did that quickly.

@angelozerr
Copy link
Contributor Author

There are some tests which are disabled

@angelozerr
Copy link
Contributor Author

There is too à test at

lemminx/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/services/format/experimental/XMLFormatterPreserveAttributeLineBreaksTest.java

Line 184 in 4cd0a54

settings.getFormattingSettings().setEmptyElement(EmptyElements.collapse);

@angelozerr angelozerr reopened this Jul 12, 2022
@JessicaJHee JessicaJHee mentioned this issue Sep 20, 2022
Merged
@angelozerr angelozerr added this to the 0.22.0 milestone Sep 21, 2022
@datho7561 datho7561 added the enhancement New feature or request label Sep 22, 2022
@JessicaJHee JessicaJHee mentioned this issue Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JessicaJHee JessicaJHee

Labels
enhancement New feature or request formatting This issue or enhancement is related to formatting support
Projects
None yet
Milestone
0.22.0
Development

Successfully merging a pull request may close this issue.

Support emptyElements settings with experimental formatter JessicaJHee/lemminx
3 participants
@angelozerr @datho7561 @JessicaJHee