Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support xml.format.joinCDATALines setting with experimental formatter #1241

Closed
angelozerr opened this issue Jul 1, 2022 · 2 comments · Fixed by #1292
Closed

Support xml.format.joinCDATALines setting with experimental formatter #1241

angelozerr opened this issue Jul 1, 2022 · 2 comments · Fixed by #1292
Assignees
@JessicaJHee
Labels
enhancement New feature or request formatting This issue or enhancement is related to formatting support
Milestone
0.22.0

Comments

@angelozerr
Copy link
Contributor

See https://github.com/redhat-developer/vscode-xml/blob/master/docs/Formatting.md#xmlformatjoincdatalines
@angelozerr angelozerr added the formatting This issue or enhancement is related to formatting support label Jul 1, 2022
@rgrunber
Copy link
Contributor

rgrunber commented Aug 31, 2022 •
edited by angelozerr

Maybe this can also fix redhat-developer/vscode-xml#719?

It should be nice too to check if it fixes #1193 by writing some tests with the expected format that user explains.

@JessicaJHee
Copy link
Contributor

I'm interested in working on this!

@JessicaJHee JessicaJHee mentioned this issue Sep 9, 2022
Merged
@datho7561 datho7561 added this to the 0.22.0 milestone Sep 14, 2022
@datho7561 datho7561 added the enhancement New feature or request label Sep 14, 2022
@JessicaJHee JessicaJHee mentioned this issue Sep 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JessicaJHee JessicaJHee

Labels
enhancement New feature or request formatting This issue or enhancement is related to formatting support
Projects
None yet
Milestone
0.22.0
Development

Successfully merging a pull request may close this issue.

Support joinCDATALines setting with experimental formatter JessicaJHee/lemminx
4 participants
@rgrunber @angelozerr @datho7561 @JessicaJHee