Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use root element for XMLClientSettings #257

Closed
dhuebner opened this issue Dec 6, 2018 · 3 comments
Closed

Use root element for XMLClientSettings #257

dhuebner opened this issue Dec 6, 2018 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@dhuebner
Copy link
Contributor

dhuebner commented Dec 6, 2018

I'm about to add support for the lsp4xml in theia. In theia, when sending settings to a server, one or more roots can be selected (in my case it's xml). Doing so, all the xml.* setting will be send to the server wrapped by the root object.

"xml": {
     "logs":{"client":true},
     "format":{"enabled":true,"spaceBeforeEmptyCloseTag":true},
     "trace":{"server":"off"}
    }

The idea behind that is that the server may later rely on other client settings e.g. http to get the proxy settings, than you would just add a new xml sibling http

Would it be possible to load the setting with a xml prefix?
Does it make sense?

@dhuebner
Copy link
Contributor Author

dhuebner commented Dec 6, 2018

@angelozerr
Copy link
Contributor

@fbricon what do you think about that?

@fbricon
Copy link
Contributor

fbricon commented Dec 6, 2018

@angelozerr I'm fine with that. That was actually what I expected from the server initially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants