Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use kill -0 instead of ps -p in ParentProcessWatcher #936

Closed
fbricon opened this issue Nov 27, 2020 · 0 comments · Fixed by #939
Closed

Use kill -0 instead of ps -p in ParentProcessWatcher #936

fbricon opened this issue Nov 27, 2020 · 0 comments · Fixed by #939
Labels
bug Something isn't working
Milestone
0.15.0

Comments

@fbricon
Copy link
Contributor

fbricon commented Nov 27, 2020

To prevent some crashes when running in WSL Alpine Linux (see redhat-developer/vscode-java#1711), we need to use kill -0 instead of ps -p in ParentProcessWatcher, like in https://github.com/eclipse/eclipse.jdt.ls/pull/1612/files
@fbricon fbricon added the bug Something isn't working label Nov 27, 2020
@fbricon fbricon added this to the 0.15.0 milestone Nov 27, 2020
@fbricon fbricon changed the title Use kill -0 instead of ps -p Use kill -0 instead of ps -p in ParentProcessWatcher Nov 27, 2020
@fbricon fbricon mentioned this issue Dec 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

Replace 'ps -p' with 'kill -0' in ParentProcessWatcher fbricon/lemminx
1 participant
@fbricon