Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON messages going to LS have URIs with non-ASCII chars #358

Closed
BoykoAlex opened this issue Jan 12, 2023 · 1 comment
Closed

JSON messages going to LS have URIs with non-ASCII chars #358

BoykoAlex opened this issue Jan 12, 2023 · 1 comment

Comments

@BoykoAlex
Copy link
Contributor

A URI to a file named: ClassWithSpécialCharacter.java (note non-ASCII é in the name) in its string form in the JSON still looks the same without é escaped. VSCode LSP client sends this url with file name that looks like: ClassWithSp%C3%A9cialCharacter.java which is correct. URIs with unicode chars are illegal... The issue I have faced is Paths(URI.create(uriStr)) throws java.lang.IllegalArgumentException: Bad escape

Test project with such file: https://github.com/spring-projects/sts4/tree/main/headless-services/spring-boot-language-server/src/test/resources/test-projects/test-annotation-indexing-parent/test-annotation-indexing%20with%20space

@BoykoAlex
Copy link
Contributor Author

Should be fixed now. Will see if lsp4j will have anything in addition via eclipse-lsp4j/lsp4j#692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant