Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE when using multiple languages client for same file extension #492

Closed
sbouchet opened this issue Feb 27, 2023 · 5 comments
Closed

NPE when using multiple languages client for same file extension #492

sbouchet opened this issue Feb 27, 2023 · 5 comments

Comments

@sbouchet
Copy link

sbouchet commented Feb 27, 2023 •
edited
Loading

using latest snapshot from https://download.eclipse.org/lsp4e/snapshots/. when opening a simple java file, i get the following npe.

Thread [main] (Suspended (exception java.lang.NullPointerException))	
	owns: org.eclipse.swt.widgets.RunnableLock  (id=327)	
	java.lang.String.compareTo(java.lang.String) line: 2013	
	java.lang.String.compareTo(java.lang.Object) line: 140	
	java.util.Comparator<T>.lambda$comparing$77a9974f$1(java.util.function.Function, java.lang.Object, java.lang.Object) line: 473	
	java.util.Comparator$$Lambda$69.0x0000000800cc0908.compare(java.lang.Object, java.lang.Object) line: not available	
	java.util.Comparators$NullComparator<T>.compare(T, T) line: 85	
	java.util.TimSort<T>.countRunAndMakeAscending(T[], int, int, java.util.Comparator<? super T>) line: 355	
	java.util.TimSort<T>.sort(T[], int, int, java.util.Comparator<? super T>, T[], int, int) line: 220	
	java.util.Arrays.sort(T[], int, int, java.util.Comparator<? super T>) line: 1307	
	java.util.ArrayList<E>.sort(java.util.Comparator<? super E>) line: 1721	
	org.eclipse.lsp4e.LanguageServers$LanguageServerProjectExecutor.getServers() line: 347	
	org.eclipse.lsp4e.LanguageServers$LanguageServerProjectExecutor(org.eclipse.lsp4e.LanguageServers<E>).anyMatching() line: 222	
	org.eclipse.lsp4e.operations.codeactions.LSPCodeActionMarkerResolution.checkMarkerResoultion(org.eclipse.core.resources.IMarker) line: 128	
	org.eclipse.lsp4e.operations.codeactions.LSPCodeActionMarkerResolution.hasResolutions(org.eclipse.core.resources.IMarker) line: 214	
	org.eclipse.ui.internal.ide.registry.MarkerHelpRegistry.hasResolution(org.eclipse.core.resources.IMarker, org.eclipse.core.runtime.IConfigurationElement, org.eclipse.ui.IMarkerResolutionGenerator) line: 264	
	org.eclipse.ui.internal.ide.registry.MarkerHelpRegistry.hasResolutions(org.eclipse.core.resources.IMarker) line: 234	
	org.eclipse.jdt.internal.ui.text.correction.JavaCorrectionProcessor.hasCorrections(org.eclipse.core.resources.IMarker) line: 148	
	org.eclipse.jdt.internal.ui.text.correction.JavaCorrectionProcessor.hasCorrections(org.eclipse.jface.text.source.Annotation) line: 138	
	org.eclipse.jdt.internal.ui.text.correction.JavaCorrectionProcessor.canFix(org.eclipse.jface.text.source.Annotation) line: 525	
	org.eclipse.jdt.internal.ui.text.correction.JavaCorrectionAssistant(org.eclipse.jface.text.quickassist.QuickAssistAssistant).canFix(org.eclipse.jface.text.source.Annotation) line: 130	
	org.eclipse.ui.texteditor.DefaultMarkerAnnotationAccess.hasQuickFix(org.eclipse.jface.text.source.Annotation) line: 439	
	org.eclipse.ui.texteditor.DefaultMarkerAnnotationAccess.getImage(org.eclipse.jface.text.source.Annotation, org.eclipse.ui.texteditor.AnnotationPreference, java.lang.String) line: 393	
	org.eclipse.ui.texteditor.DefaultMarkerAnnotationAccess.paint(org.eclipse.jface.text.source.Annotation, org.eclipse.swt.graphics.GC, org.eclipse.swt.widgets.Canvas, org.eclipse.swt.graphics.Rectangle) line: 268	
	org.eclipse.jface.text.source.AnnotationRulerColumn.doPaint1(org.eclipse.swt.graphics.GC) line: 809	
	org.eclipse.jface.text.source.AnnotationRulerColumn.doubleBufferPaint(org.eclipse.swt.graphics.GC) line: 546	
	org.eclipse.jface.text.source.AnnotationRulerColumn.lambda$1(org.eclipse.swt.events.PaintEvent) line: 274	
	org.eclipse.jface.text.source.AnnotationRulerColumn$$Lambda$728.0x00000008014ab4c8.paintControl(org.eclipse.swt.events.PaintEvent) line: not available	
	org.eclipse.swt.widgets.TypedListener.handleEvent(org.eclipse.swt.widgets.Event) line: 234	
	org.eclipse.swt.widgets.EventTable.sendEvent(org.eclipse.swt.widgets.Event) line: 89	
	org.eclipse.swt.widgets.Display.sendEvent(org.eclipse.swt.widgets.EventTable, org.eclipse.swt.widgets.Event) line: 5855	
	org.eclipse.jface.text.source.AnnotationRulerColumn$4(org.eclipse.swt.widgets.Widget).sendEvent(org.eclipse.swt.widgets.Event) line: 1529	
	org.eclipse.jface.text.source.AnnotationRulerColumn$4(org.eclipse.swt.widgets.Widget).sendEvent(int, org.eclipse.swt.widgets.Event, boolean) line: 1555	
	org.eclipse.jface.text.source.AnnotationRulerColumn$4(org.eclipse.swt.widgets.Widget).sendEvent(int, org.eclipse.swt.widgets.Event) line: 1538	
	org.eclipse.jface.text.source.AnnotationRulerColumn$4(org.eclipse.swt.widgets.Control).gtk_draw(long, long) line: 3891	
	org.eclipse.jface.text.source.AnnotationRulerColumn$4(org.eclipse.swt.widgets.Scrollable).gtk_draw(long, long) line: 365	
	org.eclipse.jface.text.source.AnnotationRulerColumn$4(org.eclipse.swt.widgets.Composite).gtk_draw(long, long) line: 506	
	org.eclipse.jface.text.source.AnnotationRulerColumn$4(org.eclipse.swt.widgets.Canvas).gtk_draw(long, long) line: 174	
	org.eclipse.jface.text.source.AnnotationRulerColumn$4(org.eclipse.swt.widgets.Widget).windowProc(long, long, long) line: 2482	
	org.eclipse.jface.text.source.AnnotationRulerColumn$4(org.eclipse.swt.widgets.Control).windowProc(long, long, long) line: 6834	
	org.eclipse.swt.widgets.Display.windowProc(long, long, long) line: 6163	
	org.eclipse.swt.internal.gtk3.GTK3.gtk_main_do_event(long) line: not available [native method]	
	org.eclipse.swt.widgets.Display.eventProc(long, long) line: 1597	
	org.eclipse.swt.internal.gtk3.GTK3.gtk_main_iteration_do(boolean) line: not available [native method]	
	org.eclipse.swt.browser.WebKit$Webkit2AsyncToSync.execAsyncAndWaitForReturn(org.eclipse.swt.browser.Browser, java.util.function.Consumer<java.lang.Integer>, java.lang.String) line: 1282	
	org.eclipse.swt.browser.WebKit$Webkit2AsyncToSync.runjavascript(java.lang.String, org.eclipse.swt.browser.Browser, long) line: 1030	
	org.eclipse.swt.browser.WebKit.execute(java.lang.String) line: 897	
	org.jboss.tools.central.internal.browser.VersionedBrowser(org.eclipse.swt.browser.Browser).execute(java.lang.String) line: 538	
	org.jboss.tools.central.internal.browser.VersionedBrowser.<init>(org.eclipse.swt.widgets.Composite, int) line: 35	
	org.jboss.tools.central.editors.GettingStartedHtmlPage.createBrowserSection(org.eclipse.swt.widgets.Composite) line: 188	
	org.jboss.tools.central.editors.GettingStartedHtmlPage.createFormContent(org.eclipse.ui.forms.IManagedForm) line: 175	
	org.jboss.tools.central.editors.GettingStartedHtmlPage(org.eclipse.ui.forms.editor.FormPage).lambda$0() line: 166	
	org.eclipse.ui.forms.editor.FormPage$$Lambda$1116.0x00000008018ad8d0.run() line: not available	
	org.eclipse.swt.custom.BusyIndicator.showWhile(org.eclipse.swt.widgets.Display, java.lang.Runnable) line: 67	
	org.jboss.tools.central.editors.GettingStartedHtmlPage(org.eclipse.ui.forms.editor.FormPage).createPartControl(org.eclipse.swt.widgets.Composite) line: 166	
	org.jboss.tools.central.editors.JBossCentralEditor(org.eclipse.ui.forms.editor.FormEditor).pageChange(int) line: 480	
	org.jboss.tools.central.editors.JBossCentralEditor(org.eclipse.ui.part.MultiPageEditorPart).setActivePage(int) line: 1030	
	org.jboss.tools.central.editors.JBossCentralEditor(org.eclipse.ui.forms.editor.FormEditor).setActivePage(int) line: 612	
	org.jboss.tools.central.editors.JBossCentralEditor(org.eclipse.ui.forms.editor.SharedHeaderFormEditor).createPages() line: 109	
	org.jboss.tools.central.editors.JBossCentralEditor(org.eclipse.ui.part.MultiPageEditorPart).createPartControl(org.eclipse.swt.widgets.Composite) line: 333	
	org.eclipse.ui.internal.e4.compatibility.CompatibilityEditor(org.eclipse.ui.internal.e4.compatibility.CompatibilityPart).createPartControl(org.eclipse.ui.IWorkbenchPart, org.eclipse.swt.widgets.Composite) line: 158	
	org.eclipse.ui.internal.e4.compatibility.CompatibilityEditor.createPartControl(org.eclipse.ui.IWorkbenchPart, org.eclipse.swt.widgets.Composite) line: 96	
	org.eclipse.ui.internal.e4.compatibility.CompatibilityEditor(org.eclipse.ui.internal.e4.compatibility.CompatibilityPart).create() line: 365	
	jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.lang.reflect.Method, java.lang.Object, java.lang.Object[]) line: not available [native method]	
	jdk.internal.reflect.NativeMethodAccessorImpl.invoke(java.lang.Object, java.lang.Object[]) line: 77	
	jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.lang.Object, java.lang.Object[]) line: 43	
	java.lang.reflect.Method.invoke(java.lang.Object, java.lang.Object...) line: 568	
	org.eclipse.e4.core.internal.di.MethodRequestor.execute() line: 58	
	org.eclipse.e4.core.internal.di.InjectorImpl.processAnnotated(java.lang.Class<? extends java.lang.annotation.Annotation>, java.lang.Object, java.lang.Class<?>, org.eclipse.e4.core.di.suppliers.PrimaryObjectSupplier, org.eclipse.e4.core.di.suppliers.PrimaryObjectSupplier, java.util.ArrayList<java.lang.Class<?>>) line: 995	
	org.eclipse.e4.core.internal.di.InjectorImpl.processAnnotated(java.lang.Class<? extends java.lang.annotation.Annotation>, java.lang.Object, java.lang.Class<?>, org.eclipse.e4.core.di.suppliers.PrimaryObjectSupplier, org.eclipse.e4.core.di.suppliers.PrimaryObjectSupplier, java.util.ArrayList<java.lang.Class<?>>) line: 960	
	org.eclipse.e4.core.internal.di.InjectorImpl.internalInject(java.lang.Object, org.eclipse.e4.core.di.suppliers.PrimaryObjectSupplier, org.eclipse.e4.core.di.suppliers.PrimaryObjectSupplier) line: 140	
	org.eclipse.e4.core.internal.di.InjectorImpl.internalMake(java.lang.Class<?>, org.eclipse.e4.core.di.suppliers.PrimaryObjectSupplier, org.eclipse.e4.core.di.suppliers.PrimaryObjectSupplier) line: 403	
	org.eclipse.e4.core.internal.di.InjectorImpl.make(java.lang.Class<T>, org.eclipse.e4.core.di.suppliers.PrimaryObjectSupplier) line: 330	
	org.eclipse.e4.core.contexts.ContextInjectionFactory.make(java.lang.Class<T>, org.eclipse.e4.core.contexts.IEclipseContext) line: 202	
	org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.createFromBundle(org.osgi.framework.Bundle, org.eclipse.e4.core.contexts.IEclipseContext, org.eclipse.e4.core.contexts.IEclipseContext, org.eclipse.emf.common.util.URI) line: 91	
	org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.doCreate(java.lang.String, org.eclipse.e4.core.contexts.IEclipseContext, org.eclipse.e4.core.contexts.IEclipseContext) line: 60	
	org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.create(java.lang.String, org.eclipse.e4.core.contexts.IEclipseContext) line: 42	
	org.eclipse.e4.ui.workbench.renderers.swt.ContributedPartRenderer.createWidget(org.eclipse.e4.ui.model.application.ui.MUIElement, java.lang.Object) line: 132	
	org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createWidget(org.eclipse.e4.ui.model.application.ui.MUIElement, java.lang.Object) line: 995	
	org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(org.eclipse.e4.ui.model.application.ui.MUIElement, java.lang.Object, org.eclipse.e4.core.contexts.IEclipseContext) line: 659	
	org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(org.eclipse.e4.ui.model.application.ui.MUIElement) line: 763	
	org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$2.run() line: 728	
	org.eclipse.core.runtime.SafeRunner.run(org.eclipse.core.runtime.ISafeRunnable) line: 45	
	org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createGui(org.eclipse.e4.ui.model.application.ui.MUIElement) line: 712	
	org.eclipse.e4.ui.internal.workbench.PartServiceImpl.lambda$0(org.osgi.service.event.Event) line: 105	
	org.eclipse.e4.ui.internal.workbench.PartServiceImpl$$Lambda$351.0x0000000801027138.handleEvent(org.osgi.service.event.Event) line: not available	
	org.eclipse.e4.ui.services.internal.events.UIEventHandler.lambda$0(org.osgi.service.event.Event) line: 38	
	org.eclipse.e4.ui.services.internal.events.UIEventHandler$$Lambda$290.0x0000000801019ad0.run() line: not available	
	org.eclipse.ui.internal.UISynchronizer(org.eclipse.swt.widgets.Synchronizer).syncExec(java.lang.Runnable) line: 183	
	org.eclipse.ui.internal.UISynchronizer.syncExec(java.lang.Runnable) line: 133	
	org.eclipse.swt.widgets.Display.syncExec(java.lang.Runnable) line: 5960	
	org.eclipse.e4.ui.workbench.swt.DisplayUISynchronize.syncExec(java.lang.Runnable) line: 34	
	org.eclipse.e4.ui.services.internal.events.UIEventHandler.handleEvent(org.osgi.service.event.Event) line: 38	
	org.eclipse.equinox.internal.event.EventHandlerWrapper.handleEvent(org.osgi.service.event.Event, java.security.Permission) line: 205	
	org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(org.eclipse.equinox.internal.event.EventHandlerWrapper, java.security.Permission, int, org.osgi.service.event.Event) line: 203	
	org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(java.lang.Object, java.lang.Object, int, java.lang.Object) line: 1	
	org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(java.util.Set<java.util.Map.Entry<K,V>>, org.eclipse.osgi.framework.eventmgr.EventDispatcher<K,V,E>, int, E) line: 234	
	org.eclipse.osgi.framework.eventmgr.ListenerQueue<K,V,E>.dispatchEventSynchronous(int, E) line: 151	
	org.eclipse.equinox.internal.event.EventAdminImpl.dispatchEvent(org.osgi.service.event.Event, boolean) line: 133	
	org.eclipse.equinox.internal.event.EventAdminImpl.sendEvent(org.osgi.service.event.Event) line: 75	
	org.eclipse.equinox.internal.event.EventComponent.sendEvent(org.osgi.service.event.Event) line: 44	
	org.eclipse.e4.ui.services.internal.events.EventBroker.send(java.lang.String, java.lang.Object) line: 55	
	org.eclipse.e4.ui.internal.workbench.UIEventPublisher.notifyChanged(org.eclipse.emf.common.notify.Notification) line: 63	
	org.eclipse.e4.ui.model.application.ui.basic.impl.PartStackImpl(org.eclipse.emf.common.notify.impl.BasicNotifierImpl).eNotify(org.eclipse.emf.common.notify.Notification) line: 424	
	org.eclipse.e4.ui.model.application.ui.basic.impl.PartStackImpl(org.eclipse.e4.ui.model.application.ui.impl.ElementContainerImpl<T>).setSelectedElementGen(T) line: 170	
	org.eclipse.e4.ui.model.application.ui.basic.impl.PartStackImpl(org.eclipse.e4.ui.model.application.ui.impl.ElementContainerImpl<T>).setSelectedElement(T) line: 188	
	org.eclipse.e4.ui.internal.workbench.ModelServiceImpl.showElementInWindow(org.eclipse.e4.ui.model.application.ui.basic.MWindow, org.eclipse.e4.ui.model.application.ui.MUIElement) line: 660	
	org.eclipse.e4.ui.internal.workbench.ModelServiceImpl.bringToTop(org.eclipse.e4.ui.model.application.ui.MUIElement) line: 624	
	org.eclipse.e4.ui.internal.workbench.PartServiceImpl.delegateBringToTop(org.eclipse.e4.ui.model.application.ui.basic.MPart) line: 790	
	org.eclipse.e4.ui.internal.workbench.PartServiceImpl.bringToTop(org.eclipse.e4.ui.model.application.ui.basic.MPart) line: 401	
	org.eclipse.e4.ui.internal.workbench.PartServiceImpl.showPart(org.eclipse.e4.ui.model.application.ui.basic.MPart, org.eclipse.e4.ui.workbench.modeling.EPartService$PartState) line: 1264	
	org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(org.eclipse.ui.IEditorInput, java.lang.String, boolean, int, org.eclipse.ui.IMemento, boolean) line: 3210	
	org.eclipse.ui.internal.WorkbenchPage.lambda$9(org.eclipse.ui.IEditorPart[], org.eclipse.ui.IEditorInput, java.lang.String, boolean, int, org.eclipse.ui.IMemento, boolean, org.eclipse.ui.PartInitException[]) line: 3100	
	org.eclipse.ui.internal.WorkbenchPage$$Lambda$1086.0x000000080161fc00.run() line: not available	
	org.eclipse.swt.custom.BusyIndicator.showWhile(org.eclipse.swt.widgets.Display, java.lang.Runnable) line: 67	
	org.eclipse.ui.internal.WorkbenchPage.openEditor(org.eclipse.ui.IEditorInput, java.lang.String, boolean, int, org.eclipse.ui.IMemento, boolean) line: 3098	
	org.eclipse.ui.internal.WorkbenchPage.openEditor(org.eclipse.ui.IEditorInput, java.lang.String, boolean, int) line: 3068	
	org.eclipse.ui.internal.WorkbenchPage.openEditor(org.eclipse.ui.IEditorInput, java.lang.String) line: 3051	
	org.jboss.tools.central.JBossCentralActivator.openJBossCentralEditor(org.eclipse.ui.IWorkbenchPage) line: 439	
	org.jboss.tools.central.JBossCentralActivator.getJBossCentralEditor(boolean) line: 427	
	org.jboss.tools.central.ShowJBossCentral$2.run() line: 110	
	org.eclipse.swt.widgets.RunnableLock.run(org.eclipse.swt.widgets.Display) line: 40	
	org.eclipse.ui.internal.UISynchronizer(org.eclipse.swt.widgets.Synchronizer).runAsyncMessages(boolean) line: 132	
	org.eclipse.swt.widgets.Display.runAsyncMessages(boolean) line: 5040	
	org.eclipse.swt.widgets.Display.readAndDispatch() line: 4520	
	org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run() line: 1155	
	org.eclipse.core.databinding.observable.Realm.runWithDefault(org.eclipse.core.databinding.observable.Realm, java.lang.Runnable) line: 338	
	org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(org.eclipse.e4.ui.model.application.MApplicationElement, org.eclipse.e4.core.contexts.IEclipseContext) line: 1046	
	org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(org.eclipse.e4.ui.model.application.MApplicationElement) line: 155	
	org.eclipse.ui.internal.Workbench.lambda$3(org.eclipse.swt.widgets.Display, org.eclipse.ui.application.WorkbenchAdvisor, int[]) line: 643	
	org.eclipse.ui.internal.Workbench$$Lambda$203.0x0000000800efc000.run() line: not available	
	org.eclipse.core.databinding.observable.Realm.runWithDefault(org.eclipse.core.databinding.observable.Realm, java.lang.Runnable) line: 338	
	org.eclipse.ui.internal.Workbench.createAndRunWorkbench(org.eclipse.swt.widgets.Display, org.eclipse.ui.application.WorkbenchAdvisor) line: 550	
	org.eclipse.ui.PlatformUI.createAndRunWorkbench(org.eclipse.swt.widgets.Display, org.eclipse.ui.application.WorkbenchAdvisor) line: 171	
	org.eclipse.ui.internal.ide.application.IDEApplication.start(org.eclipse.equinox.app.IApplicationContext) line: 152	
	org.eclipse.equinox.internal.app.EclipseAppHandle.run(java.lang.Object) line: 203	
	org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(java.lang.Object) line: 136	
	org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(java.lang.Object) line: 104	
	org.eclipse.core.runtime.adaptor.EclipseStarter.run(java.lang.Object) line: 402	
	org.eclipse.core.runtime.adaptor.EclipseStarter.run(java.lang.String[], java.lang.Runnable) line: 255	
	jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.lang.reflect.Method, java.lang.Object, java.lang.Object[]) line: not available [native method]	
	jdk.internal.reflect.NativeMethodAccessorImpl.invoke(java.lang.Object, java.lang.Object[]) line: 77	
	jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.lang.Object, java.lang.Object[]) line: 43	
	java.lang.reflect.Method.invoke(java.lang.Object, java.lang.Object...) line: 568	
	org.eclipse.equinox.launcher.Main.invokeFramework(java.lang.String[], java.net.URL[]) line: 659	
	org.eclipse.equinox.launcher.Main.basicRun(java.lang.String[]) line: 596	
	org.eclipse.equinox.launcher.Main.run(java.lang.String[]) line: 1467	
	org.eclipse.equinox.launcher.Main.main(java.lang.String[]) line: 1440

break points shows 3 LS in the getservers().

  • JBoss Qute
  • JBoss Quarkus
  • org.eclipse.lsp4e.LanguageClientImpl

below the plugin.xml that implies Qute and Quarkus are registered for java files:

   <extension
         point="org.eclipse.lsp4e.languageServer">
      <server
            class="org.jboss.tools.quarkus.lsp4e.QuarkusLanguageServer"
            id="org.jboss.tools.quarkus.lsp4e"
            label="Quarkus Language Server"
            clientImpl="org.jboss.tools.quarkus.lsp4e.QuarkusLanguageClient"
            serverInterface="org.eclipse.lsp4mp.ls.api.MicroProfileLanguageServerAPI"
            singleton="true" >
      </server>
      <contentTypeMapping
            contentType="org.jboss.tools.quarkus.lsp4e.properties"
            id="org.jboss.tools.quarkus.lsp4e">
      </contentTypeMapping>
      <contentTypeMapping
            contentType="org.eclipse.jdt.core.javaSource"
            id="org.jboss.tools.quarkus.lsp4e">
      </contentTypeMapping>
      <server
            class="org.jboss.tools.quarkus.lsp4e.internal.ls.qute.QuteLanguageServer"
            id="org.jboss.tools.quarkus.lsp4e.qute"
            label="Qute Language Server"
            clientImpl="org.jboss.tools.quarkus.lsp4e.internal.ls.qute.QuteLanguageClient"
            serverInterface="com.redhat.qute.ls.api.QuteLanguageServerAPI"
            singleton="true" >
      </server>
      <contentTypeMapping
            contentType="org.jboss.tools.quarkus.lsp4e.qute.html"
            id="org.jboss.tools.quarkus.lsp4e.qute">
      </contentTypeMapping>
      <contentTypeMapping
            contentType="org.jboss.tools.quarkus.lsp4e.qute.yaml"
            id="org.jboss.tools.quarkus.lsp4e.qute">
      </contentTypeMapping>
      <contentTypeMapping
            contentType="org.jboss.tools.quarkus.lsp4e.qute.json"
            id="org.jboss.tools.quarkus.lsp4e.qute">
      </contentTypeMapping>
      <contentTypeMapping
            contentType="org.jboss.tools.quarkus.lsp4e.qute.txt"
            id="org.jboss.tools.quarkus.lsp4e.qute">
      </contentTypeMapping>
      <contentTypeMapping
            contentType="org.jboss.tools.quarkus.lsp4e.qute"
            id="org.jboss.tools.quarkus.lsp4e.qute">
      </contentTypeMapping>
      <contentTypeMapping
            contentType="org.eclipse.jdt.core.javaSource"
            id="org.jboss.tools.quarkus.lsp4e.qute">
      </contentTypeMapping>
   </extension>
@sbouchet sbouchet mentioned this issue Feb 27, 2023
Closed
@rubenporras
Copy link
Contributor

Thanks for the report, I will create a fix

@angelozerr
Copy link
Contributor

A simple fix is to return an empty String instead of null at

lsp4e/org.eclipse.lsp4e/src/org/eclipse/lsp4e/operations/codeactions/LSPCodeActionMarkerResolution.java

Line 167 in 0584590

return null;

But I don't know if it is a proper fix.

@mickaelistria
Copy link
Contributor

If the null case if problematic, there we should instead return an Optional here to make things clear.

@rubenporras rubenporras mentioned this issue Feb 28, 2023
Merged
@sbouchet
Copy link
Author

thing was that is was working ok in 0.21.0

@rubenporras
Copy link
Contributor

Hi @sbouchet , could you test with the newest snapshot that will be soon available and reopen if the bug is still present?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mickaelistria @sbouchet @angelozerr @rubenporras